Skip to content

Commit 94e97c5

Browse files
authored
fix: resolve linting errors in test files (#8672)
1 parent 7a3c47d commit 94e97c5

7 files changed

Lines changed: 10 additions & 13 deletions

File tree

pkg/campaign/orchestrator_test.go

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -64,10 +64,10 @@ func TestBuildOrchestrator_BasicShape(t *testing.T) {
6464

6565
func TestBuildOrchestrator_NoTrackerLabelDoesNotMentionTracker(t *testing.T) {
6666
spec := &CampaignSpec{
67-
ID: "test-campaign",
68-
Name: "Test Campaign",
69-
ProjectURL: "https://github.com/orgs/test/projects/1",
70-
Workflows: []string{"test-workflow"},
67+
ID: "test-campaign",
68+
Name: "Test Campaign",
69+
ProjectURL: "https://github.com/orgs/test/projects/1",
70+
Workflows: []string{"test-workflow"},
7171
TrackerLabel: "",
7272
}
7373

pkg/campaign/template_test.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -96,8 +96,8 @@ func TestRenderProjectUpdateInstructions(t *testing.T) {
9696
{
9797
name: "with project URL and campaign ID",
9898
data: CampaignPromptData{
99-
ProjectURL: "https://github.com/orgs/test/projects/1",
100-
CampaignID: "my-campaign",
99+
ProjectURL: "https://github.com/orgs/test/projects/1",
100+
CampaignID: "my-campaign",
101101
},
102102
shouldContain: []string{
103103
"Project Board Integration",

pkg/cli/compile_integration_test.go

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,6 @@ package cli
44

55
import (
66
"bytes"
7-
"context"
87
"io"
98
"os"
109
"os/exec"

pkg/cli/interfaces_test.go

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -27,21 +27,21 @@ func TestCommandProviderInterface(t *testing.T) {
2727
t.Run("GenBashCompletion", func(t *testing.T) {
2828
var buf bytes.Buffer
2929
err := provider.GenBashCompletion(&buf)
30-
assert.NoError(t, err, "GenBashCompletion should not error")
30+
require.NoError(t, err, "GenBashCompletion should not error")
3131
assert.NotEmpty(t, buf.String(), "GenBashCompletion should generate content")
3232
})
3333

3434
t.Run("GenZshCompletion", func(t *testing.T) {
3535
var buf bytes.Buffer
3636
err := provider.GenZshCompletion(&buf)
37-
assert.NoError(t, err, "GenZshCompletion should not error")
37+
require.NoError(t, err, "GenZshCompletion should not error")
3838
assert.NotEmpty(t, buf.String(), "GenZshCompletion should generate content")
3939
})
4040

4141
t.Run("GenFishCompletion", func(t *testing.T) {
4242
var buf bytes.Buffer
4343
err := provider.GenFishCompletion(&buf, true)
44-
assert.NoError(t, err, "GenFishCompletion should not error")
44+
require.NoError(t, err, "GenFishCompletion should not error")
4545
assert.NotEmpty(t, buf.String(), "GenFishCompletion should generate content")
4646
})
4747
}

pkg/cli/run_command_test.go

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,6 @@
33
package cli
44

55
import (
6-
"context"
76
"fmt"
87
"strings"
98
"testing"

pkg/cli/status_command.go

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -372,7 +372,6 @@ func getMarkdownWorkflowFiles() ([]string, error) {
372372
return getMarkdownWorkflowFilesInDir(getWorkflowsDir())
373373
}
374374

375-
376375
// getMarkdownWorkflowFilesInDir finds all markdown workflow files in the provided directory.
377376
// This is primarily used for shell completions and tests to avoid relying on process-wide cwd.
378377
func getMarkdownWorkflowFilesInDir(workflowsDir string) ([]string, error) {

pkg/workflow/safe_output_validation_config.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -230,7 +230,7 @@ var ValidationConfig = map[string]TypeValidationConfig{
230230
},
231231
},
232232
"update_project": {
233-
DefaultMax: 10,
233+
DefaultMax: 10,
234234
CustomValidation: "updateProjectValidTarget",
235235
Fields: map[string]FieldValidation{
236236
"project": {Required: true, Type: "string", Sanitize: true, MaxLength: 512, Pattern: "^https://github\\.com/(orgs|users)/[^/]+/projects/\\d+", PatternError: "must be a full GitHub project URL (e.g., https://github.com/orgs/myorg/projects/42)"},

0 commit comments

Comments
 (0)