-
Notifications
You must be signed in to change notification settings - Fork 34
Refactor "mcp-inspect" to nested "mcp inspect" command structure #851
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor "mcp-inspect" to nested "mcp inspect" command structure #851
Conversation
Co-authored-by: pelikhan <[email protected]>
pkg/cli/mcp.go
Outdated
|
|
||
| // NewMCPInspectSubcommand creates the mcp inspect subcommand | ||
| // This is the former mcp-inspect command now nested under mcp | ||
| func NewMCPInspectSubcommand() *cobra.Command { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@copilot move to mcp_inspect.go
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Moved NewMCPInspectSubcommand function to mcp_inspect.go for better code organization. The mcp.go file now contains only the main MCP command structure while all inspect-related functionality is consolidated in mcp_inspect.go. Functionality verified and all tests pass. (dcf58ca)
Co-authored-by: pelikhan <[email protected]>
|
Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details. Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
pkg/cli/mcp_inspect.go
Outdated
| Examples: | ||
| gh aw mcp inspect # List workflows with MCP servers | ||
| gh aw mcp inspect weekly-research # Inspect MCP servers in weekly-research.md | ||
| gh aw mcp inspect repomind --server repo-mind # Inspect only the repo-mind server |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@copilot delete this line
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Deleted the repomind example line from the help text. The help output is now cleaner and more focused on relevant examples. (e710a8d)
Co-authored-by: pelikhan <[email protected]>
|
Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details. Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
Refactor "mcp-inspect" to "mcp inspect" nested command - COMPLETED
This PR successfully refactors the standalone
mcp-inspectcommand to a nestedmcp inspectcommand structure as requested.✅ All Changes Completed:
pkg/cli/mcp.gofile for main MCP commandinspectsubcommandgh aw mcp inspectmake agent-finishvalidation successfullyNewMCPInspectSubcommandfunction tomcp_inspect.gofor better organization✅ Code Organization Improved:
NewMCPInspectSubcommandfunction frommcp.gotomcp_inspect.gomcp.gofile now contains only the main MCP command structuremcp_inspect.gofile contains all inspect-related functionality✅ Functionality Verification:
gh aw mcp-inspectproperly returns "unknown command" errorgh aw mcp inspectworks with all flags and options🔧 Command Structure Change:
gh aw mcp-inspect [workflow-file]gh aw mcp inspect [workflow-file]📚 Documentation Updated:
docs/src/content/docs/tools/cli.md- CLI referencedocs/src/content/docs/guides/mcps.md- MCP debugging guide🧪 Testing Complete:
🏗️ Architecture:
The new structure allows for future expansion with additional MCP-related subcommands under the main
mcpcommand, providing better organization and discoverability.Ready for merge - All validations complete and successful.
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.