-
Notifications
You must be signed in to change notification settings - Fork 34
Refactor cache-memory to use simple file share with path-specific access controls, artifact management, enhanced logs integration, and frontmatter workflow naming #849
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…erver Co-authored-by: pelikhan <[email protected]>
pelikhan
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@copilot update Claude tools with Read/Write access to all files in the cache memory directory
…he-memory Co-authored-by: pelikhan <[email protected]>
Updated Claude tools with Read/Write access to cache memory directory. When cache-memory is enabled, Claude now explicitly gets Read, Write, Edit, and MultiEdit tools ensuring full file system access to Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
|
@copilot for Claude, be more precise and only provide read/write access to the cache folder when configuring cache tools |
Co-authored-by: pelikhan <[email protected]>
Made cache tools path-specific to only access the cache folder. Claude now gets precise tools: Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
|
@copilot add cqche-memory to deva genetic workflow, update dev to remember/recall the execution plan in plan.md |
Co-authored-by: pelikhan <[email protected]>
Added cache-memory to dev agentic workflow and updated it to remember/recall execution plans in plan.md. The workflow now instructs Claude to maintain Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
|
Co-authored-by: pelikhan <[email protected]>
Updated cache-memory implementation:
Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
pelikhan
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@copilot add test agentic workflow under pkg/cli/workflows that uses cache-memory
Co-authored-by: pelikhan <[email protected]>
A comprehensive test agentic workflow using cache-memory already exists at Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
|
@copilot fix tests |
Tests are now fixed. The issue was missing npm dependencies (prettier) and golangci-lint. Installed npm packages and golangci-lint, all tests and linting now pass successfully. Dependencies are excluded from git via .gitignore. Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
This PR refactors the
cache-memoryfeature to provide a simple file share approach instead of mounting MCP memory servers, making it more transparent and easier for LLMs to use.What Changed
The cache-memory feature previously mounted an MCP memory server (
@modelcontextprotocol/server-memory) that provided a specializedmemorytool. This has been replaced with a simple file share at/tmp/cache-memory/that LLMs can access using standard file operations.Key Benefits
name:field to override workflow titlesImplementation Details
Removed MCP Server Mounting
claude_engine.goandcustom_engine.goto no longer generate MCP memory server configurationsmcp__memoryfrom Claude engine's allowed tools listPath-Specific File Access Tools
Read(/tmp/cache-memory/*),Write(/tmp/cache-memory/*),Edit(/tmp/cache-memory/*),MultiEdit(/tmp/cache-memory/*)/tmp/cache-memory/directory for precise access controlEnhanced Dev Workflow
cache-memory: trueto the dev workflow configuration/tmp/cache-memory/plan.mdAlways-Upload Artifact Management
Enhanced Logs Command Integration
Frontmatter Workflow Naming Support
name:field in workflow frontmatter to override workflow titlesEnhanced LLM Prompting
Added comprehensive prompting in
compiler.gothat informs LLMs about the cache folder:/tmp/cache-memory/Updated Cache Steps
Modified cache generation in
cache.goto:Removed Deprecated Fields
DockerImagefield fromCacheMemoryConfigstructUpdated Documentation
Completely rewrote the cache-memory documentation to:
Example Usage
Before (MCP approach):
After (file share approach):
Artifact Management
Cache-memory now always generates artifact upload steps:
Workflow Naming
Workflows now support flexible naming through frontmatter:
Backward Compatibility
All existing
cache-memoryconfiguration syntax continues to work. The deprecateddocker-imagefield has been removed as it was no longer functional in the file share approach. Workflows without frontmattername:field continue to use H1 header extraction.Testing
claude_engine_tools_test.goto reflect the new path-specific tool availabilitytest-claude-cache-memory.mdto demonstrate file operationsEdit(/tmp/cache-memory/*),MultiEdit(/tmp/cache-memory/*),Read(/tmp/cache-memory/*),Write(/tmp/cache-memory/*)+ default toolsThis change simplifies the cache-memory feature while providing precise access controls, execution plan management capabilities, always-available artifact uploads for debugging, enhanced logs integration for better analysis and troubleshooting, and flexible workflow naming through frontmatter configuration.
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.