Skip to content

Conversation

Copy link
Contributor

Copilot AI commented Dec 31, 2025

Campaign workflows fail during push_repo_memory when the branch contains legacy files from previous runs that don't match current FILE_GLOB_FILTER patterns. The memory/campaigns branch has old files nested as memory/default/... from before PR #8283, which fail validation against the pattern go-file-size-reduction-project64/**.

Changes

Modified actions/setup/js/push_repo_memory.cjs:

  • Skip files that don't match glob patterns instead of failing validation
  • Log warning for skipped files with debug details
  • Glob filter now controls what gets pushed, not what's allowed in artifact

Added test coverage:

  • Test case documenting legacy file filtering behavior in push_repo_memory.test.cjs

Example

Before (fails entire push):

if (!matchResults.some(m => m)) {
  core.error(`File does not match allowed patterns: ${normalizedRelPath}`);
  core.setFailed("File pattern validation failed");
  throw new Error("File pattern validation failed");
}

After (skips non-matching files):

if (!matchResults.some(m => m)) {
  core.warning(`Skipping file that does not match allowed patterns: ${normalizedRelPath}`);
  return;  // Skip this file instead of failing
}

This enables gradual migration from old branch structures without requiring manual cleanup or workflow failures.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

  • https://api.github.com/repos/githubnext/gh-aw/actions/jobs/59216298621/logs
    • Triggering command: /usr/bin/curl curl -sL REDACTED (http block)
  • https://api.github.com/user
    • Triggering command: /usr/bin/gh gh api user --jq .login ithub/workflows -timeout=3m /usr/bin/gh integration -run=^Test ./... gh api .git --jq by/f8e27215b084c2f956dfd7867e70e6b6a52a1e1f487129228cbbdbe01cc8cde3/log.json l t /home/REDACTED/go//tmp/validate-js-3856699581.cjs /usr/lib/git-core/git (http block)
    • Triggering command: /usr/bin/gh gh api user --jq .login ithub/workflows -buildtags (http block)
    • Triggering command: /usr/bin/gh gh api user --jq .login -java.git by/f8e27215b084c2f956dfd7867e70e6b6a52a1e1f487129228cbbdbe01cc8cde3 eefa3f7014b46aae07d35b2e3bda3e084c8/log.json by/f8e27215b084cnode 8cbbdbe01cc8cde3--check l/linux_amd64/li/tmp/validate-js-2175771153.cjs infocmp -1 3440-15068/test-2943651985/.github/workflows l/linux_amd64/link /usr/bin/git runs/20251231-12/usr/bin/containerd-shim-runc-v2 -buildtags ache/node/24.12.moby git (http block)

If you need me to access, download, or install something from one of these locations, you can either:

Original prompt

Fix issue that causes failed run:
https://github.com/githubnext/gh-aw/actions/runs/20618637624/job/59216298621
Note that memory/campaigns is the branchm while the rest is the path <campaign-id>/metrics/<date>.json.


✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

Copilot AI and others added 2 commits December 31, 2025 12:32
Changed push_repo_memory.cjs to skip files that don't match the glob patterns
instead of failing validation. This allows gradual migration from old branch
structures without manual cleanup.

- When files don't match FILE_GLOB_FILTER patterns, log a warning and skip them
- This fixes failed runs where old incorrectly-nested files exist on the branch
- Added test case documenting the legacy file filtering behavior
- All 53 JavaScript tests pass

Co-authored-by: mnkiefer <[email protected]>
Copilot AI changed the title [WIP] Fix issue causing failed run in GitHub Actions Fix repo-memory validation to skip non-matching files instead of failing Dec 31, 2025
Copilot AI requested a review from mnkiefer December 31, 2025 12:48
@mnkiefer mnkiefer marked this pull request as ready for review December 31, 2025 12:55
@mnkiefer mnkiefer merged commit 5dec658 into main Dec 31, 2025
130 checks passed
@mnkiefer mnkiefer deleted the copilot/fix-failed-run-issue branch December 31, 2025 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants