Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions .changeset/patch-fix-safe-inputs-secrets.md

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 3 additions & 3 deletions .github/workflows/copilot-pr-merged-report.lock.yml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions .github/workflows/daily-choice-test.lock.yml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions .github/workflows/daily-performance-summary.lock.yml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 3 additions & 3 deletions .github/workflows/smoke-copilot-no-firewall.lock.yml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 3 additions & 3 deletions .github/workflows/smoke-copilot-playwright.lock.yml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 3 additions & 3 deletions .github/workflows/smoke-copilot-safe-inputs.lock.yml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

25 changes: 18 additions & 7 deletions pkg/workflow/mcp_servers.go
Original file line number Diff line number Diff line change
Expand Up @@ -299,19 +299,30 @@ func (c *Compiler) generateMCPSetup(yaml *strings.Builder, tools map[string]any,
// Step 4: Start the HTTP server in the background
yaml.WriteString(" - name: Start Safe Inputs MCP HTTP Server\n")
yaml.WriteString(" id: safe-inputs-start\n")

// Add env block with tool-specific secrets so they're available to the Node.js MCP server process
safeInputsSecrets := collectSafeInputsSecrets(workflowData.SafeInputs)
if len(safeInputsSecrets) > 0 {
yaml.WriteString(" env:\n")
// Sort env var names for consistent output
envVarNames := make([]string, 0, len(safeInputsSecrets))
for envVarName := range safeInputsSecrets {
envVarNames = append(envVarNames, envVarName)
}
sort.Strings(envVarNames)

for _, envVarName := range envVarNames {
secretExpr := safeInputsSecrets[envVarName]
fmt.Fprintf(yaml, " %s: %s\n", envVarName, secretExpr)
}
}

yaml.WriteString(" run: |\n")
yaml.WriteString(" # Set environment variables for the server\n")
yaml.WriteString(" export GH_AW_SAFE_INPUTS_PORT=${{ steps.safe-inputs-config.outputs.safe_inputs_port }}\n")
yaml.WriteString(" export GH_AW_SAFE_INPUTS_API_KEY=${{ steps.safe-inputs-config.outputs.safe_inputs_api_key }}\n")
yaml.WriteString(" \n")

// Pass through environment variables from safe-inputs config
envVars := getSafeInputsEnvVars(workflowData.SafeInputs)
for _, envVar := range envVars {
fmt.Fprintf(yaml, " export %s=\"${%s}\"\n", envVar, envVar)
}
yaml.WriteString(" \n")

// Call the bundled shell script to start the server
yaml.WriteString(" bash /tmp/gh-aw/actions/start_safe_inputs_server.sh\n")
yaml.WriteString(" \n")
Expand Down
Loading