docs: clarify campaign feature separation from core workflow systems #7979
+55
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Improved documentation and comments to clearly separate campaign-specific logic from general repo-memory and workflow functionality: 1. push_repo_memory.cjs: Added clear documentation sections explaining the campaign convention (memoryId="campaigns" + file-glob="<id>/**") and how campaign validation is triggered. Emphasized that this is a domain-specific convention, not mixing with general repo-memory logic. 2. tools.go: Enhanced permissions defaults section with detailed comments explaining campaign orchestrator generation pattern and why campaign.g.md files receive special permission handling at compile time. 3. compiler.go: Added comment explaining that campaign warning detection is just a feature flag check, not campaign logic integration. 4. safe_output_validation_config.go: Documented that campaign_id is an optional field in update-project safe output, used by campaigns but not required for general use. These changes preserve the clean separation between: - Campaign domain logic (pkg/campaign/) - General workflow compilation (pkg/workflow/) - Repo-memory features (generic with campaign convention support) - Safe outputs (generic with optional campaign fields) Co-authored-by: mnkiefer <[email protected]>
Copilot
AI
changed the title
[WIP] Add support for campaign objectives and KPIs
docs: clarify campaign feature separation from core workflow systems
Dec 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reviewed campaign feature integration points to ensure clean separation from ProjectOps, repo-memory, and workflow compilation. All integration uses convention-based patterns rather than architectural coupling.
Documentation Improvements
Repo-memory campaign convention (
actions/setup/js/push_repo_memory.cjs)memoryId="campaigns"+file-glob="<id>/**"triggers validationCampaign orchestrator permissions (
pkg/workflow/tools.go).campaign.g.mdfiles receive special handlingSafe output fields (
pkg/workflow/safe_output_validation_config.go)campaign_idas optional field for campaign trackingCompiler feature detection (
pkg/workflow/compiler.go).campaign.mddetection is simple feature flag, not logic integrationSeparation Confirmed
pkg/campaign/💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.