Skip to content

Conversation

Copy link
Contributor

Copilot AI commented Dec 28, 2025

The push_repo_memory.cjs file was importing @actions/core directly, but this package is not available locally in the GitHub Actions environment when running github-script actions.

Changes:

  • Removed const core = require("@actions/core") from push_repo_memory.cjs
  • File now uses global.core provided by github-script action environment
  • Aligns with pattern used by all other files in actions/setup/js/ directory

Pattern:

// Before (incorrect):
const core = require("@actions/core");

// After (correct):
// Uses global.core set by github-script action environment
// No import needed - aligns with add_comment.cjs, assign_milestone.cjs, etc.

The global.core object is established by the setup_globals.cjs helper which is invoked by github-script actions before loading workflow scripts.


💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

The file now uses global.core provided by github-script action environment,
consistent with other files in actions/setup/js/. This fixes the issue where
@actions/core package was not available locally.

Co-authored-by: mnkiefer <[email protected]>
Copy link
Contributor Author

Copilot AI commented Dec 28, 2025

Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

  • https://api.github.com/user
    • Triggering command: /usr/bin/gh gh api user --jq .login ithub/workflows 673844058/b223//-ifaceassert ux-amd64/pkg/tool/linux_amd64/vet --gdwarf-5 --64 mpile ux-amd64/pkg/too-buildtags rg/x�� pkg/mod/golang.o-errorsas mpile ux-amd64/pkg/tool/linux_amd64/vet . s140only/fips140-atomic ut-3089911928.c ux-amd64/pkg/too-buildtags (http block)
    • Triggering command: /usr/bin/gh gh api user --jq .login -x c /home/REDACTED/go/pkg/mod/golang.ojson - om/goccy/go-yamlrev-parse ux-amd64/pkg/too--show-toplevel /home/REDACTED/go/pkg/mod/[email protected] -o tags/v5 -trimpath /usr/bin/git l github.com/githurun -lang=go1.25 git (http block)
    • Triggering command: /usr/bin/gh gh api user --jq .login ithub/workflows --jq (http block)

If you need me to access, download, or install something from one of these locations, you can either:

Copilot AI changed the title [WIP] Add support for campaign objectives and KPIs fix: remove @actions/core import from push_repo_memory.cjs Dec 28, 2025
Copilot AI requested a review from mnkiefer December 28, 2025 11:58
@mnkiefer mnkiefer marked this pull request as ready for review December 28, 2025 11:58
@mnkiefer mnkiefer merged commit 999bb15 into campaign-delegation Dec 28, 2025
@mnkiefer mnkiefer deleted the copilot/sub-pr-7237 branch December 28, 2025 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants