-
Notifications
You must be signed in to change notification settings - Fork 34
Bundle shell scripts in setup action and call directly #7446
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Co-authored-by: pelikhan <[email protected]>
Co-authored-by: pelikhan <[email protected]>
Co-authored-by: pelikhan <[email protected]>
Co-authored-by: pelikhan <[email protected]>
|
@copilot merge main, recompile |
…s-setup-bundle-scripts
Smoke Test Results✅ File Writing: Created Status: PASS
|
|
OpenAI curl blocked: ✅
|
Smoke Test Results - Copilot Engine (No Firewall)Last 2 Merged PRs:
Test Results: ✅ GitHub MCP - Successfully retrieved last 2 merged PRs Overall Status: FAIL (1/5 tests failed) Note: The safeinputs-gh tool appears to not be available in this environment.
|
|
PRs: Optimize maintenance workflow schedules and fix missing GitHub MCP configuration; chore: clean up comment on github token in workflow
|
Smoke Test Results
Overall Status: PARTIAL FAIL Note: Playwright test requires proper MCP client integration, not inspector mode.
|
Bundle Shell Scripts in Setup Action
Completed:
buildSetupActioninactions_build_command.goto copy shell scripts tosh/directorysetup.shto copy shell scripts with executable permissions (chmod +x)/tmp/gh-aw/actions/directorySummary
Successfully updated the setup action to bundle shell scripts and modified the workflow compiler to call them directly instead of embedding them inline. Merged latest changes from main branch and recompiled all workflows.
Changes Made:
Added
GetBundledShellScripts()function inpkg/workflow/sh.gocheckout_pr.shandprint_safe_outputs_summary.sh(use templating)Updated
buildSetupAction()inpkg/cli/actions_build_command.goactions/setup/sh/directoryUpdated
setup.shscriptsh/directory to destinationchmod +xon all shell scriptsUpdated
ActionsCleanCommand()inpkg/cli/actions_build_command.gosh/directory for setup actionUpdated workflow compiler to call scripts directly:
compiler_yaml_main_job.go:create_gh_aw_tmp_dir.shcompiler_yaml.go:create_prompt_first.sh,print_prompt_summary.shmcp_servers.go:start_safe_inputs_server.shcache.go:create_cache_memory_dir.shUpdated documentation
actions/setup/README.mdto document shell scriptsMerged main branch
Recompiled workflows
Shell Scripts Bundled:
Included (no templating - safe to bundle):
create_gh_aw_tmp_dir.sh- Creates temporary directory structurestart_safe_inputs_server.sh- Starts safe-inputs HTTP serverprint_prompt_summary.sh- Prints prompt summary to logsgenerate_git_patch.sh- Generates git patchescreate_cache_memory_dir.sh- Creates cache-memory directorycreate_prompt_first.sh- Creates prompt directoryExcluded (uses GitHub Actions templating):
checkout_pr.sh- uses${{ github.event_name }},${{ github.event.issue.number }}print_safe_outputs_summary.sh- uses${{ env.GH_AW_SAFE_OUTPUTS }}Benefits:
Original prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.