MCP safe outputs with Claude CLI integration #726

Copilot · 2025-09-11T05:16:41Z

Recent Fix Details

Fixed failing tests by updating test expectations to match the current MCP server implementation:

✅ Tool naming consistency - Updated test expectations from underscored names (create_issue, missing_tool) to hyphenated names (create-issue, missing-tool) to match actual MCP server behavior

✅ Missing-tool prompt generation test - Updated TestMissingToolPromptGeneration to match current implementation which only adds header text without detailed instructions

✅ MCP server tool tests - Fixed all TestSafeOutputsMCPServer_* tests to use correct tool names and handle disabled tool scenarios properly

✅ Disabled tool handling - Updated disabled tool test to include at least one enabled tool for server startup and accept "Tool not found" error message for disabled tools

All tests now pass consistently without modifying the source code implementation.

✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

…ensive tests Co-authored-by: pelikhan <[email protected]>

…mports Co-authored-by: pelikhan <[email protected]>

pkg/workflow/claude_engine.go

pkg/workflow/compiler.go

pkg/workflow/custom_engine.go

Co-authored-by: pelikhan <[email protected]>

Copilot · 2025-09-11T06:06:05Z

Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

api.contoso.com
- Triggering command: /tmp/go-build2422702117/b278/cli.test -test.testlogfile=/tmp/go-build2422702117/b278/testlog.txt -test.paniconexit0 -test.timeout=10m0s -test.v=true (dns block)
- Triggering command: /tmp/go-build3736928890/b278/cli.test -test.testlogfile=/tmp/go-build3736928890/b278/testlog.txt -test.paniconexit0 -test.timeout=10m0s -test.v=true (dns block)
- Triggering command: /tmp/go-build2140046656/b278/cli.test -test.testlogfile=/tmp/go-build2140046656/b278/testlog.txt -test.paniconexit0 -test.timeout=10m0s (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

Configure Actions setup steps to set up my environment, which run before the firewall is enabled
Add the appropriate URLs or hosts to the custom allowlist in this repository's Copilot coding agent settings (admins only)

pkg/workflow/codex_engine.go

pkg/workflow/safe_outputs_mcp_server_test.go

Co-authored-by: pelikhan <[email protected]>

Copilot · 2025-09-11T12:01:15Z

Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

https://api.github.com/search/repositories
- Triggering command: curl -s REDACTED (http block)

If you need me to access, download, or install something from one of these locations, you can either:

Configure Actions setup steps to set up my environment, which run before the firewall is enabled
Add the appropriate URLs or hosts to the custom allowlist in this repository's Copilot coding agent settings (admins only)

pelikhan · 2025-09-11T14:40:02Z

@copilot revert last commit

…arnings Reverted commit b2a3f2d which downgraded MCP SDK to v0.2.0. Now back to using Go MCP SDK v0.4.0 with proper API usage: - Fixed Client.Connect calls to include nil ClientSessionOptions parameter - Replaced deprecated NewCommandTransport with CommandTransport struct literal - Replaced deprecated NewStreamableClientTransport with StreamableClientTransport struct literal - All tests passing and linter clean Co-authored-by: pelikhan <[email protected]>

Copilot · 2025-09-11T15:05:57Z

@copilot revert last commit

Reverted commit b2a3f2d as requested. Now back to using Go MCP SDK v0.4.0 with proper API usage and fixed deprecation warnings. Commit: 8f15ff6

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

api.contoso.com
- Triggering command: /tmp/go-build1680963516/b279/cli.test -test.testlogfile=/tmp/go-build1680963516/b279/testlog.txt -test.paniconexit0 -test.timeout=10m0s -test.v=true (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

Configure Actions setup steps to set up my environment, which run before the firewall is enabled
Add the appropriate URLs or hosts to the custom allowlist in this repository's Copilot coding agent settings (admins only)

pelikhan · 2025-09-11T15:37:20Z

@copilot add a test in the vitest JavaScript test suite that uses the MCP typescript SDK to list tools, call tools, validate file is generated.

Co-authored-by: pelikhan <[email protected]>

…s across workflows

…mpatibility

…nsistency

…racking

…ts MCP server

…s workflows

…ng across workflows

…14d1-4802-81ec-ee5946e7c01c

…ling

…nclude data

…cessing across workflows

…workflow files

…proved environment variable handling

…c01c

pelikhan · 2025-09-15T20:53:08Z

@copilot fix the tests, do not modify the source code.

Co-authored-by: pelikhan <[email protected]>

Copilot · 2025-09-15T21:08:45Z

@copilot fix the tests, do not modify the source code.

Fixed the failing tests by updating test expectations to match the current MCP server implementation. Key changes:

Updated tool naming conventions from underscores to hyphens (e.g., create_issue → create-issue)
Fixed missing-tool prompt generation test to match actual implementation behavior
Updated disabled tool test to handle server startup and error message expectations correctly

All tests now pass without modifying source code. Commit: 1e57d70

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

api.contoso.com
- Triggering command: /tmp/go-build2921975893/b279/cli.test -test.testlogfile=/tmp/go-build2921975893/b279/testlog.txt -test.paniconexit0 -test.timeout=10m0s -test.v=true (dns block)
- Triggering command: /tmp/go-build1023522378/b279/cli.test -test.testlogfile=/tmp/go-build1023522378/b279/testlog.txt -test.paniconexit0 -test.timeout=10m0s -test.v=true (dns block)
- Triggering command: /tmp/go-build275948141/b279/cli.test -test.testlogfile=/tmp/go-build275948141/b279/testlog.txt -test.paniconexit0 -test.timeout=10m0s -test.v=true (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

Configure Actions setup steps to set up my environment, which run before the firewall is enabled
Add the appropriate URLs or hosts to the custom allowlist in this repository's Copilot coding agent settings (admins only)

…c01c

…726) * Initial plan * Implement run-doctor workflow for CI failure investigation Co-authored-by: pelikhan <[email protected]> * Merge branch 'main' into copilot/fix-725 * Add missing workflow_run expressions to allow run-doctor workflow compilation Co-authored-by: pelikhan <[email protected]> * Remove user-controlled strings from workflow_run expressions for security Co-authored-by: pelikhan <[email protected]> * Merge remote-tracking branch 'origin/main' into copilot/fix-725 * Merge remote-tracking branch 'origin/main' into copilot/fix-725 * Merge branch 'main' into copilot/fix-725 * Remove unused GitHub Actions workflow_run expressions from AllowedExpressions * Merge branch 'main' into copilot/fix-725

Initial plan

218c4c7

Copilot AI assigned Copilot and pelikhan Sep 11, 2025

Copilot started work on behalf of pelikhan September 11, 2025 05:16 View session

Copilot AI and others added 2 commits September 11, 2025 05:41

Implement TypeScript/Node.js MCP server for safe-outputs with compreh…

70264fa

…ensive tests Co-authored-by: pelikhan <[email protected]>

Fix nil pointer dereference in MCP config generation and deprecated i…

c83c4f1

…mports Co-authored-by: pelikhan <[email protected]>

Copilot AI requested a review from pelikhan September 11, 2025 05:49

Copilot finished work on behalf of pelikhan September 11, 2025 05:49

pelikhan reviewed Sep 11, 2025

View reviewed changes

pkg/workflow/claude_engine.go Outdated Show resolved Hide resolved

pkg/workflow/compiler.go Outdated Show resolved Hide resolved

pkg/workflow/custom_engine.go Outdated Show resolved Hide resolved

Copilot started work on behalf of pelikhan September 11, 2025 05:56 View session

Refactor hasSafeOutputsEnabled to common helper in safe_outputs.go

7fa5c48

Co-authored-by: pelikhan <[email protected]>

Copilot finished work on behalf of pelikhan September 11, 2025 06:06

Copilot AI requested a review from pelikhan September 11, 2025 06:06

pelikhan reviewed Sep 11, 2025

View reviewed changes

pkg/workflow/codex_engine.go Outdated Show resolved Hide resolved

pkg/workflow/safe_outputs_mcp_server_test.go Show resolved Hide resolved

Copilot started work on behalf of pelikhan September 11, 2025 11:40 View session

Copilot AI and others added 2 commits September 11, 2025 11:54

Refactor codex engine to use common HasSafeOutputsEnabled helper

3f3f2f0

Co-authored-by: pelikhan <[email protected]>

Keep MCP SDK version at v0.2.0 for compatibility

b2a3f2d

Co-authored-by: pelikhan <[email protected]>

Copilot AI requested a review from pelikhan September 11, 2025 12:01

Copilot finished work on behalf of pelikhan September 11, 2025 12:01

Copilot started work on behalf of pelikhan September 11, 2025 14:40 View session

Copilot finished work on behalf of pelikhan September 11, 2025 15:07

Copilot started work on behalf of pelikhan September 11, 2025 15:37 View session

Add comprehensive MCP TypeScript SDK integration test for safe-outputs

22ada79

Co-authored-by: pelikhan <[email protected]>

pelikhan added 17 commits September 15, 2025 19:12

fix clause safe-output mcp

d3a6b0e

Refactor MCP server configuration to consistently include safe_output…

b98fabe

…s across workflows

Update MCP server environment variables to use context-aware syntax

782f2ae

fix: update GITHUB_AW_SAFE_OUTPUTS_CONFIG to use toJSON for better co…

0004fe0

…mpatibility

fix: update GITHUB_AW_SAFE_OUTPUTS_CONFIG to use toJSON syntax for co…

c183a95

…nsistency

fix: update GITHUB_AW_SAFE_OUTPUTS_CONFIG to use toJSON syntax for co…

68abb6e

…nsistency

fix: add debug logging for safe outputs MCP server to improve error t…

a5eb42f

…racking

fix: refactor message handling to use newline protocol for safe outpu…

fcc6818

…ts MCP server

fix: update message handling to improve logging and null checks acros…

cbc0bed

…s workflows

fix: refactor defaultHandler to remove async and improve error handli…

6e9d256

…ng across workflows

Merge remote-tracking branch 'origin/main' into copilot/fix-dab7400a-…

c39a738

…14d1-4802-81ec-ee5946e7c01c

fix: add debug logging to ignore notification methods in message hand…

83855d5

…ling

fix: improve error handling in replyError function to conditionally i…

168957a

…nclude data

fix: enhance debug logging and error handling in JSON-RPC message pro…

4f53066

…cessing across workflows

fix: update notification regex to match 'notifications/' in multiple …

1bbe7ea

…workflow files

fix: enhance missing tools reporting with structured summaries and im…

98948ec

…proved environment variable handling

Merge branch 'main' into copilot/fix-dab7400a-14d1-4802-81ec-ee5946e7…

c9a8ae7

…c01c

Copilot started work on behalf of pelikhan September 15, 2025 20:53 View session

fix: update test expectations to match current MCP server implementation

1e57d70

Co-authored-by: pelikhan <[email protected]>

Copilot finished work on behalf of pelikhan September 15, 2025 21:09

pelikhan added 4 commits September 15, 2025 14:14

Merge branch 'main' into copilot/fix-dab7400a-14d1-4802-81ec-ee5946e7…

aafcdc9

…c01c

format

7b94ba7

refactor: remove obsolete test file for safe_outputs_mcp_server

bd0f9e9

Merge branch 'main' into copilot/fix-dab7400a-14d1-4802-81ec-ee5946e7…

5516831

…c01c

pelikhan merged commit 3904d93 into main Sep 15, 2025
10 checks passed

pelikhan deleted the copilot/fix-dab7400a-14d1-4802-81ec-ee5946e7c01c branch September 15, 2025 21:25

Mossaka mentioned this pull request Sep 30, 2025

fix: build script now works on MacOS #1102

Closed

MCP safe outputs with Claude CLI integration #726

MCP safe outputs with Claude CLI integration #726

Uh oh!

Conversation

Copilot AI commented Sep 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Recent Fix Details

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI commented Sep 11, 2025

I tried to connect to the following addresses, but was blocked by firewall rules:

Uh oh!

Uh oh!

Uh oh!

Copilot AI commented Sep 11, 2025

I tried to connect to the following addresses, but was blocked by firewall rules:

Uh oh!

pelikhan commented Sep 11, 2025

Uh oh!

Copilot AI commented Sep 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

I tried to connect to the following addresses, but was blocked by firewall rules:

Uh oh!

pelikhan commented Sep 11, 2025

Uh oh!

pelikhan commented Sep 15, 2025

Uh oh!

Copilot AI commented Sep 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

I tried to connect to the following addresses, but was blocked by firewall rules:

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Copilot AI commented Sep 11, 2025 •

edited

Loading

Copilot AI commented Sep 11, 2025 •

edited

Loading

Copilot AI commented Sep 15, 2025 •

edited

Loading