-
Notifications
You must be signed in to change notification settings - Fork 34
Add title deduplication for safe output descriptions #6088
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add title deduplication for safe output descriptions #6088
Conversation
Co-authored-by: pelikhan <[email protected]>
|
@copilot register helper in script registry, bundler |
Co-authored-by: pelikhan <[email protected]>
This comment has been minimized.
This comment has been minimized.
|
@copilot review bundling to make sure the new helper gets treated as GitHub script and bundled |
Test Hide Older Comments - Run Complete ✅Workflow Run ID: 20121471273 This comment was generated to test the This is an automated test comment
|
Co-authored-by: pelikhan <[email protected]>
Done in cdf1997. The
|
|
📰 BREAKING: Smoke Copilot is now investigating this pull request. Sources say the story is developing... |
|
🔮 The ancient spirits stir... Smoke Codex awakens to divine this pull request... |
|
🎉 Yo ho ho! Changeset Generator found the treasure and completed successfully! ⚓💰 |
|
💥 WHOOSH! Smoke Claude springs into action on this pull request! [Panel 1 begins...] |
|
📰 BREAKING: Smoke Copilot Playwright is now investigating this pull request. Sources say the story is developing... |
|
Last 2 PRs: #6073 (hide-older-comments), #6083 (runtime-import) Status: PASS
|
|
Smoke test results:
|
Smoke Test ResultsRecent PRs:
Test Results:
Status: PASS (5/6 tests passed)
|
Smoke Test Results (Run 20121774253)✅ Playwright MCP: Successfully navigated to https://github.com - page title verified: "GitHub · Change is constant. GitHub keeps you ahead. · GitHub" Status: FAIL (1/3 tests passed)
|
Smoke Test Results (Run #20121774251)Test Results:
Overall Status: FAIL The safeinputs-gh tool has configuration issues preventing GitHub API access. 📰🔥📋 https://github.com/githubnext/gh-aw/actions/runs/20121774251 fer issue #6088 🗺️ |
Implementation Complete
removeDuplicateTitleFromDescription(title, description)inpkg/workflow/js/remove_duplicate_title.cjspkg/workflow/js/remove_duplicate_title.test.cjs(50 tests)create_issue.cjs,create_discussion.cjs,create_pull_request.cjsupdate_issue.cjsandupdate_pull_request.cjsviaupdate_runner.cjs//go:embeddirective forremove_duplicate_title.cjsinpkg/workflow/js.goGetJavaScriptSources()map for bundlingChanges
The helper function is now properly registered in the bundler system:
pkg/workflow/js.go//go:embed js/remove_duplicate_title.cjsdirective"remove_duplicate_title.cjs": removeDuplicateTitleScripttoGetJavaScriptSources()mapOriginal prompt
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.
Changeset