Skip to content

Conversation

Copy link
Contributor

Copilot AI commented Sep 26, 2025

Renames the docker_image_version field to version for GitHub and Playwright tool configurations, as this field applies to both libraries and containers, not just Docker images.

Problem

The current docker_image_version field name is misleading since it's used for both Docker containers and other library versions. A more generic version field name better represents its purpose.

Changes

This PR replaces the docker_image_version field with the new version field. The legacy field is no longer supported:

New syntax:

tools:
  github:
    version: "v2.0.0"
    allowed: [create_issue]
  playwright:
    version: "v1.41.0"
    allowed_domains: ["example.com"]

Legacy syntax (no longer supported):

tools:
  github:
    docker_image_version: "v1.5.0"  # ❌ Will cause validation error
    allowed: [create_issue]
  playwright:
    docker_image_version: "v1.40.0"  # ❌ Will cause validation error
    allowed_domains: ["example.com"]

Implementation Details

  • Core functions: Updated getGitHubDockerImageVersion() and getPlaywrightDockerImageVersion() to only check version field
  • MCP parser: Updated to only handle version field in configuration parsing
  • Schema validation: Updated JSON schema to only recognize version field
  • Documentation: All examples now use the new version field

Testing

  • Updated unit tests to only test the version field functionality
  • All existing tests continue to pass (384+ tests)
  • Manual CLI testing confirms version field works correctly with schema validation
  • Verified that docker_image_version field now properly fails validation

The change provides a cleaner, more semantically appropriate field name without backward compatibility complexity.

Original prompt

rename "docker-image-version" field to "version" as it applies both to libraries and containers


💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

Copilot AI changed the title [WIP] rename "docker-image-version" field to "version" as it applies both to libraries and containers Rename "docker_image_version" field to "version" with backward compatibility Sep 26, 2025
Copilot AI requested a review from pelikhan September 26, 2025 14:50
Copy link
Contributor

@pelikhan pelikhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@copilot remove support for docker_image_version

Copy link
Contributor Author

Copilot AI commented Sep 26, 2025

@copilot remove support for docker_image_version

Removed backward compatibility support for docker_image_version. The system now only accepts the version field. Updated code, schema, and tests accordingly. Commit: e7a3ff2

Copilot AI changed the title Rename "docker_image_version" field to "version" with backward compatibility Rename "docker_image_version" field to "version" Sep 26, 2025
Copilot AI requested a review from pelikhan September 26, 2025 15:05
@pelikhan pelikhan marked this pull request as ready for review September 26, 2025 15:10
@pelikhan pelikhan merged commit bfa0d2a into main Sep 26, 2025
15 of 16 checks passed
@pelikhan pelikhan deleted the copilot/fix-7f5f58cb-014e-4bdf-a77b-ffc30e54a96b branch September 26, 2025 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants