-
Notifications
You must be signed in to change notification settings - Fork 34
Move safe-jobs frontmatter section under safe-outputs as jobs and refactor internal data structure #1022
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move safe-jobs frontmatter section under safe-outputs as jobs and refactor internal data structure #1022
Conversation
Co-authored-by: pelikhan <[email protected]>
Co-authored-by: pelikhan <[email protected]>
…8998-4ac8-aab4-033825814d65
…itions for print functionality
|
@copilot remove SafeJobs field from WorkflowData and use SafeOutputs.Jobs instead. This should simplify checks if safe-outputs feature is enabled. |
Co-authored-by: pelikhan <[email protected]>
Completed in commit dc1b45d. Removed the |
Co-authored-by: pelikhan <[email protected]>
…ty and error handling - Simplified environment variable checks and JSON parsing in create_discussion.js and create_issue.js. - Enhanced logging for better debugging and user feedback. - Streamlined the process of creating discussions and issues, including handling related issues and comments. - Improved handling of discussion categories and issue labels. - Added checks for repository settings to ensure discussions and issues can be created.
…tps://github.com/githubnext/gh-aw into copilot/fix-39eac2c3-8998-4ac8-aab4-033825814d65
Only create SafeOutputsConfig when there are safe jobs to populate
This change optimizes the SafeOutputs initialization logic to only create a new
SafeOutputsConfiginstance when there are actually safe jobs to populate (len(includedSafeJobs) > 0). Previously, the code would always create an emptySafeOutputsConfigeven when there were no safe jobs to populate, which was unnecessary.Changes Made:
Optimization:
SafeOutputsConfigto checklen(includedSafeJobs) > 0workflowData.SafeOutputsbefore populating jobsSafeOutputsConfiginstances when not neededLogic:
SafeOutputsConfigwhen there are actual safe jobs to populateSafeOutputs.JobsThis addresses the code review feedback to make the SafeOutputs creation more efficient and only allocate memory when necessary.
Original prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.