test(runtimes/dotnet): add unit and integration tests for dotnet runtime#460
Merged
jamesadevine merged 2 commits intomainfrom May 8, 2026
Merged
test(runtimes/dotnet): add unit and integration tests for dotnet runtime#460jamesadevine merged 2 commits intomainfrom
jamesadevine merged 2 commits intomainfrom
Conversation
Agent-Logs-Url: https://github.com/githubnext/ado-aw/sessions/6be26aa9-cced-401f-8e64-2a878a523571 Co-authored-by: jamesadevine <4742697+jamesadevine@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Add tests for dotnet runtime gap analysis
test(runtimes/dotnet): add unit and integration tests for dotnet runtime
May 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Test-gap analysis flagged the
runtimes/dotnetmodule as having 0 direct tests forgenerate_dotnet_install/generate_ensure_nuget_configand no end-to-end compile coverage. Note: mostDotnetExtension::validate()branches called out in the issue are already covered insrc/compile/extensions/tests.rs, so this PR fills only the genuine gaps.Summary
src/runtimes/dotnet/mod.rs— new#[cfg(test)] mod testsblock:generate_dotnet_install: default (8.0.x), explicit version,global.jsonsentinel (emitsuseGlobalJson: true, drops explicit version), case-insensitive sentinel.generate_ensure_nuget_config: feed URL is interpolated into the heredoc with valid XML; default falls back tohttps://api.nuget.org/v3/index.json.tests/compiler_tests.rs— two E2E tests modeled ontest_lean_runtime_compiled_output:test_dotnet_runtime_compiled_output—runtimes: dotnet: trueemitsUseDotNet@2, default8.0.x,dotnetin the bash allow-list, andnuget.orgin the AWF allow-domains.test_dotnet_runtime_with_feed_url_compiled_output—feed-url:additionally emits the ensure-nuget.configshim andNuGetAuthenticate@1.No production code changed.
Test plan
cargo test: 1231 unit (+6) / 82 integration (+2) / 3 init / 8 mcp-http — all pass.cargo clippy --all-targets --all-features— clean (only pre-existing warnings).Warning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
spsprodeus21.vssps.visualstudio.com/home/REDACTED/work/ado-aw/ado-aw/target/debug/deps/ado_aw-632c4d56de6fcebc /home/REDACTED/work/ado-aw/ado-aw/target/debug/deps/ado_aw-632c4d56de6fcebc --emit=dep-info,metadata -C embed-bitcode=no -C debuginfo=2 --check-cfg /lib.rs --check-cfg cfg(feature, values()) -C metadata=212eb341856bbdc9 know�� known-linux-gnu/--error-format=json known-linux-gnu/--json=diagnostic-rendered-ansi,artifacts,future-incompat bin/rustc known-linux-gnu/cc -incompat known-linux-gnu/-Wl,--no-undefined-version bin/rustc(dns block)/home/REDACTED/work/ado-aw/ado-aw/target/debug/deps/ado_aw-632c4d56de6fcebc /home/REDACTED/work/ado-aw/ado-aw/target/debug/deps/ado_aw-632c4d56de6fcebc target/debug/depremote target/debug/depget-url stable-x86_64-unorigin s/li�� -linux-gnu/crti.o target/debug/deps/ado_aw-3a32340b03e006cd.0ig5wf--json=diagnostic-rendered-ansi,artifacts,futureremote stable-x86_64-REDACTED-linux-gnu/bin/rustc target/debug/depgit artifacts,futureremote target/debug/depget-url stable-x86_64-unorigin targ�� target/debug/deps/ado_aw-3a32340b03e006cd.0v3laa--error-format=json target/debug/deps/ado_aw-3a32340b03e006cd.0w908s--json=diagnostic-rendered-ansi,artifacts,futureremote stable-x86_64-REDACTED-linux-gnu/lib/rustlib/x86_64-REDACTED-linux-gnu/bin/cc k/ado-aw/ado-aw/git artifacts,futureremote rs -gnu/lib/libgimlorigin(dns block)spsprodweu4.vssps.visualstudio.com/home/REDACTED/work/ado-aw/ado-aw/target/debug/deps/ado_aw-632c4d56de6fcebc /home/REDACTED/work/ado-aw/ado-aw/target/debug/deps/ado_aw-632c4d56de6fcebc --emit=dep-info,metadata -C embed-bitcode=no -C debuginfo=2 --check-cfg /lib.rs --check-cfg cfg(feature, values()) -C metadata=212eb341856bbdc9 know�� known-linux-gnu/--error-format=json known-linux-gnu/--json=diagnostic-rendered-ansi,artifacts,future-incompat bin/rustc known-linux-gnu/cc -incompat known-linux-gnu/-Wl,--no-undefined-version bin/rustc(dns block)/home/REDACTED/work/ado-aw/ado-aw/target/debug/deps/ado_aw-632c4d56de6fcebc /home/REDACTED/work/ado-aw/ado-aw/target/debug/deps/ado_aw-632c4d56de6fcebc target/debug/depremote target/debug/depget-url stable-x86_64-unorigin s/li�� -linux-gnu/crti.o target/debug/deps/ado_aw-3a32340b03e006cd.0ig5wf--json=diagnostic-rendered-ansi,artifacts,futureremote stable-x86_64-REDACTED-linux-gnu/bin/rustc target/debug/depgit artifacts,futureremote target/debug/depget-url stable-x86_64-unorigin targ�� target/debug/deps/ado_aw-3a32340b03e006cd.0v3laa--error-format=json target/debug/deps/ado_aw-3a32340b03e006cd.0w908s--json=diagnostic-rendered-ansi,artifacts,futureremote stable-x86_64-REDACTED-linux-gnu/lib/rustlib/x86_64-REDACTED-linux-gnu/bin/cc k/ado-aw/ado-aw/git artifacts,futureremote rs -gnu/lib/libgimlorigin(dns block)If you need me to access, download, or install something from one of these locations, you can either: