test: add coverage for MCP tools list and upload tool execute dispatch#462
Merged
jamesadevine merged 3 commits intomainfrom May 8, 2026
Merged
Conversation
Agent-Logs-Url: https://github.com/githubnext/ado-aw/sessions/5e191e2d-ba3d-4aff-bc93-fcef93bb03cd Co-authored-by: jamesadevine <4742697+jamesadevine@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Add test gaps for new MCP tools in gap analysis
test: add coverage for MCP tools list and upload tool execute dispatch
May 8, 2026
Collaborator
|
@copilot resolve the merge conflicts in this pull request |
Co-authored-by: jamesadevine <4742697+jamesadevine@users.noreply.github.com>
Contributor
Author
Resolved in fb39d59. The conflict was in |
jamesadevine
approved these changes
May 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes test gaps from the gap-finder report: the MCP
tools/listintegration test asserted only 5 of ~20 registered tools (missing both upload tools), and the execute-dispatch arms forupload-workitem-attachmentandupload-build-attachmenthad zero direct coverage.Summary
tests/mcp_http_tests.rs— extendtest_mcp_initialize_and_tools_listwith asserts forupload-workitem-attachmentandupload-build-attachmentso a broken MCP registration on either tool fails the suite.src/execute.rs— add 4 unit tests mirroring the existingupdate-wiki-page/comment-on-work-itempatterns to exercise the dispatch arms:test_execute_malformed_upload_workitem_attachment_returns_errtest_execute_upload_workitem_attachment_missing_contexttest_execute_malformed_upload_build_attachment_returns_errtest_execute_upload_build_attachment_missing_contextmainintests/mcp_http_tests.rswheremainadded anupload-pipeline-artifactassertion in the same block; kept all three upload assertions (upload-workitem-attachment,upload-build-attachment,upload-pipeline-artifact).Note: the issue refers to
upload-build-artifact, but the actually-registered tool name isupload-build-attachment(seesrc/mcp.rs:994,src/execute.rs:352). Tests use the real name.Test plan
cargo test --bin ado-aw execute::tests::test_execute_malformed_upload→ 2 passedcargo test --bin ado-aw execute::tests::test_execute_upload→ 2 passed (missing_context)cargo test --test mcp_http_tests test_mcp_initialize_and_tools_list→ passed (after merge withmain)cargo test --bin ado-aw execute::tests::test_execute_→ all 24 execute tests passed after merge