feat!: remove taskstoissues from core by mnriem · Pull Request #5053 · github/spec-kit

mnriem · 2026-10-21T15:51:11Z

Description

Remove taskstoissues from core templates, command inventories, integration metadata, generated-command expectations, and core documentation. Keep the existing GitHub extension unchanged, with its documentation confined to extensions/github/README.md.

No compatibility alias, new migration behavior, or command-specific legacy-artifact checks. Update affected tests for the reduced core command set. Bump the extension patch version only as required for its README changes.

Testing

Tested locally with uv run specify --help
Ran existing tests with uv sync && uv run pytest
Tested with a sample project (if applicable)

Used the worktree-local interpreter instead of the test command above:
.venv/bin/python -m pytest tests/extensions/github/test_github_extension.py tests/specify_cli/integrations/test_command_upgrade.py -q — 251 passed, 1 skipped. uv run specify --help and git diff --check passed. No live issue creation was performed.

AI Disclosure

I did not use AI assistance for this contribution
I did use AI assistance (fill in the disclosure below)

AI disclosure: GitHub Copilot, GPT-6.1 Sol (gpt-6.1-sol), autonomous with default runtime reasoning settings, on behalf of @mnriem. AI-generated code, tests, documentation, commits, and PR description; scope and GitHub updates authorized by the contributor. No human line-by-line review is claimed.

Make the opt-in github extension the sole owner of taskstoissues, including a deprecated compatibility alias. Preserve hook behavior, register aliases in skills mode, restore extension-backed preset overrides, and document the breaking migration for the next minor release. Refs github#4423 Assisted-by: GitHub Copilot (model: GPT-6.1 Sol, autonomous) Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

Copilot

🔵 Needs a closer look

Unresolved alias safety and lifecycle defects, together with breaking-release sequencing, require maintainer review.

3 open issues

What changed in this PR

Moves GitHub issue creation out of Spec Kit’s core workflow and into the opt-in github extension.

Changes:

Remove core taskstoissues scaffolding and inventories.
Add compatibility aliases and update skill lifecycle handling.
Expand migration documentation and regression coverage.

AI disclosure: GitHub Copilot; model unavailable; autonomous review and fix suggestions for the requester.

File	Description
tests/test_extensions.py	Retarget core-name collision tests.
tests/specify_cli/presets/test_manager_skills.py	Cover extension-backed alias restoration.
tests/specify_cli/integrations/test_command_upgrade.py	Cover legacy artifact migration.
tests/integrations/test_integration_generic.py	Expand alias and collision coverage.
tests/integrations/test_integration_copilot.py	Update core command expectations.
tests/integrations/test_integration_bob.py	Update core skill expectations.
tests/integrations/test_integration_base_yaml.py	Remove retired command expectations.
tests/integrations/test_integration_base_toml.py	Remove retired command expectations.
tests/integrations/test_integration_base_skills.py	Update core skill inventories.
tests/integrations/test_integration_base_markdown.py	Update core command inventory.
tests/extensions/github/test_taskstoissues_removal.py	Add removal and compatibility contracts.
tests/extensions/github/test_taskstoissues_deprecation.py	Delete obsolete core deprecation tests.
tests/extensions/github/test_github_extension.py	Expand alias rendering and compatibility coverage.
templates/commands/taskstoissues.md	Delete the core command template.
src/specify_cli/presets/_manager_skills.py	Restore aliases and extension script paths.
src/specify_cli/integrations/copilot/__init__.py	Remove retired core command entry.
src/specify_cli/integrations/claude/__init__.py	Remove retired argument hint.
src/specify_cli/integrations/base.py	Remove retired command ordering entry.
src/specify_cli/integrations/alquimia/__init__.py	Remove retired argument hint.
src/specify_cli/extensions/__init__.py	Register and track skill aliases.
src/specify_cli/__init__.py	Remove retired skill description.
README.md	Announce the breaking migration.
extensions/github/README.md	Explain alias ownership and migration.
extensions/github/extension.yml	Declare alias and raise host requirement.
extensions/github/commands/speckit.github.taskstoissues.md	Add alias-specific warning.
extensions/EXTENSION-USER-GUIDE.md	Clarify extension-owned hook events.
extensions/EXTENSION-DEVELOPMENT-GUIDE.md	Update alias rules and hook ownership.
extensions/EXTENSION-API-REFERENCE.md	Update alias and hook contracts.
extensions/catalog.json	Update bundled GitHub extension version.
docs/upgrade.md	Provide ordered migration instructions.
docs/reference/integrations.md	Document opt-in issue conversion.
docs/reference/extensions.md	Clarify extension-owned invocations.
docs/reference/agentic-sdd.md	Describe the opt-in workflow.
docs/installation.md	Update available-command guidance.
docs/community/presets.md	Flag preset migration requirements.
CHANGELOG.md	Record removal and minor-release requirement.

_{Review effort: Max}

Drop the conditional compatibility alias and revert its shared registration, cleanup, and preset-restoration support. Keep the existing GitHub extension unchanged and cover core-command retirement and explicit opt-in migration without an alias. Assisted-by: GitHub Copilot (model: GPT-6.1 Sol, autonomous) Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

mnriem · 2026-10-21T16:38:16Z

Narrowed this PR to core-command removal and migration in e6e904e. Removed the conditional compatibility alias and reverted its shared registration/cleanup and preset-restoration support. The alias-specific paths raised in this review are no longer introduced by the PR; general alias lifecycle support is deferred rather than expanded here. The bundled GitHub extension's manifest, command prompt, version, and minimum host version are unchanged.

The full suite was rerun on the narrowed implementation: LC_ALL=en_US.UTF-8 .venv/bin/python -m pytest -q passed with 12,749 passed, 101 skipped, and 62 warnings. Collection remains above the original baseline: 12,850 versus 12,839. Updated the PR description with the narrowed scope, migration instructions, exact validation commands/results, and manual-testing limitations. Reviewer conversations remain unresolved for the reviewer to assess.

AI disclosure: Posted on behalf of @mnriem by GitHub Copilot using GPT-6.1 Sol (gpt-6.1-sol), autonomous execution with default runtime reasoning settings. The agent generated the review fixes, tests, documentation, and this summary, ran validation, and committed/pushed the changes with the contributor's authorization; no human line-by-line review is claimed.

Copilot

🟡 Changes recommended

Release handling and Hermes cleanup guidance need correction before the breaking removal can ship safely.

2 open issues

3 resolved since last review

_{Review effort: Max}

Remove added migration documentation and replacement tests. Delete obsolete core-only and core-parity tests while retaining existing extension and shared prerequisite-script coverage. Restrict documentation edits to removing obsolete core content; leave release tooling and Hermes lifecycle behavior unchanged. Assisted-by: GitHub Copilot (model: GPT-6.1 Sol, autonomous) Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

Copilot

🟡 Changes recommended

The breaking migration lacks removal-specific test coverage and public upgrade guidance.

5 open issues

2 resolved since last review

_{Review effort: Max}

+layouts under its configured `--commands-dir`.

-| Deprecated core command   | Recommended extension command     |
+| Core command              | Recommended extension command     |


+            "speckit-tasks/SKILL.md"
+            if skills_mode else "speckit.tasks.md"


 - `after_constitution` - After constitution update
- `before_taskstoissues` - Before tasks-to-issues conversion
- `after_taskstoissues` - After tasks-to-issues conversion



Assisted-by: GitHub Copilot (model: GPT-6.1 Sol, autonomous) Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

mnriem · 2026-10-29T21:06:12Z

Addressed this review in commit 491a895: added the breaking-removal notice and later-minor-release sequencing requirement, documented integration upgrade before optional extension installation, clarified forced deletion and customization migration, restored the extension-owned taskstoissues hook documentation, and added no-alias and CLI-backed migration coverage for command/skills layouts with GitHub absent or already installed. The bundled GitHub extension patch version is bumped so the revised migration README reaches existing installations. No legacy alias or CLI release-version change was introduced.

AI-generated summary posted on behalf of @mnriem by GitHub Copilot (model: GPT-6.1 Sol; autonomous execution with user-authorized push and posting). The changes and validation were agent-performed; no human line-by-line review is claimed.

Copilot

🟡 Changes recommended

The regression test allows aliases that restore the legacy invocation, while upgrade guidance risks overwritten customizations and omits replacement-command setup for non-default integrations.

7 open issues

2 resolved since last review

_{Review effort: Max}

Resolve upstream documentation moves, restore the no-aliases guard, and correct migration backup, activation, and published-link guidance. Assisted-by: GitHub Copilot (model: GPT-6.1 Sol, autonomous) Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

Preserve upstream documentation moves and regression tests while retaining the taskstoissues removal and its migration guidance. Assisted-by: GitHub Copilot (model: GPT-6.1 Sol, autonomous) Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

Copilot

🟡 Changes recommended

The upgrade guidance omits cleanup of persistent Hermes skills, tests lose skip-existing-issue assertions, and the handwritten changelog section conflicts with release automation.

4 open issues

4 resolved since last review

_{Review effort: Max}

        # Four-digit and longer task IDs must still match.
        assert r"\bT\d{3,}\b" in body


Copilot

🟡 Changes recommended

Deleting the regression test leaves the sole GitHub extension prompt’s duplicate-prevention instructions untested, allowing them to be removed without any test failing.

5 open issues

_{Review effort: Max}

Remove command-specific migration guidance and hook references from core docs and drop added legacy-artifact migration checks. Keep extension documentation in its README without changing the existing backup warning. Assisted-by: GitHub Copilot (model: GPT-6.1 Sol, autonomous) Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

Copilot

🟡 Changes recommended

Still-active hook events are missing from the reference, and migration guidance fails to distinguish unchanged event names from hook command bindings that need auditing.

5 open issues

1 resolved since last review

Clarify the full overwrite scope of --force

_{Review effort: Max}

+Audit references to `speckit.taskstoissues`
 in presets, extension prompts, workflow steps, handoffs, and project automation.


Copilot AI max review requested due to automatic review settings October 21, 2026 15:51

Copilot started reviewing on behalf of mnriem October 21, 2026 15:51

View session

Copilot AI reviewed Oct 21, 2026

View reviewed changes

Comment thread src/specify_cli/extensions/__init__.py Resolved

Comment thread extensions/github/extension.yml Resolved

Comment thread src/specify_cli/extensions/__init__.py Resolved

Copilot AI max review requested due to automatic review settings October 21, 2026 16:37

Copilot started reviewing on behalf of mnriem October 21, 2026 16:38

View session

Copilot AI reviewed Oct 21, 2026

View reviewed changes

Comment thread CHANGELOG.md Resolved

Comment thread docs/upgrade.md Resolved

Copilot AI max review requested due to automatic review settings October 21, 2026 17:44

Copilot started reviewing on behalf of mnriem October 21, 2026 17:45

View session

Copilot AI reviewed Oct 21, 2026

View reviewed changes

mnriem added the triage-can-wait Verdict: valid and in-scope but deprioritized; held behind the evidence gate label Oct 21, 2026

fix: document and cover taskstoissues removal migration

491a895

Assisted-by: GitHub Copilot (model: GPT-6.1 Sol, autonomous) Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

Copilot AI max review requested due to automatic review settings October 29, 2026 21:06

Copilot started reviewing on behalf of mnriem October 29, 2026 21:06

View session

Copilot AI reviewed Oct 29, 2026

View reviewed changes

Comment thread tests/extensions/github/test_github_extension.py Resolved

Comment thread CHANGELOG.md Resolved

Comment thread docs/upgrade.md Resolved

Comment thread docs/upgrade.md Resolved

Copilot AI max review requested due to automatic review settings October 30, 2026 13:21

Copilot started reviewing on behalf of mnriem October 30, 2026 13:22

View session

Copilot AI reviewed Oct 30, 2026

View reviewed changes

Comment thread tests/extensions/github/test_github_extension.py

Comment on lines 587 to 588

# Four-digit and longer task IDs must still match.

assert r"\bT\d{3,}\b" in body

Copilot AI max review requested due to automatic review settings October 30, 2026 13:40

Copilot started reviewing on behalf of mnriem October 30, 2026 13:40

View session

Copilot stopped reviewing on behalf of mnriem due to an error October 30, 2026 14:35
Copilot had to stop work due to a timeout.

Copilot started reviewing on behalf of mnriem October 30, 2026 14:36

View session

Copilot AI reviewed Oct 30, 2026

View reviewed changes

Comment thread docs/upgrade.md Resolved

Copilot AI max review requested due to automatic review settings October 30, 2026 17:13

Copilot started reviewing on behalf of mnriem October 30, 2026 17:14

View session

Copilot AI reviewed Oct 30, 2026

View reviewed changes

Comment thread extensions/github/README.md

Comment on lines +128 to 129

Audit references to `speckit.taskstoissues`

in presets, extension prompts, workflow steps, handoffs, and project automation.

		"speckit-tasks/SKILL.md"
		if skills_mode else "speckit.tasks.md"

		# Four-digit and longer task IDs must still match.
		assert r"\bT\d{3,}\b" in body

		Audit references to `speckit.taskstoissues`
		in presets, extension prompts, workflow steps, handoffs, and project automation.

Conversation

mnriem commented Oct 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Testing

AI Disclosure

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

🔵 Needs a closer look

Uh oh!

Uh oh!

Uh oh!

Uh oh!

mnriem commented Oct 21, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

🟡 Changes recommended

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

🟡 Changes recommended

Uh oh!

Uh oh!

Uh oh!

mnriem commented Oct 29, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

🟡 Changes recommended

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

🟡 Changes recommended

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

🟡 Changes recommended

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

🟡 Changes recommended

Uh oh!

This branch has not been deployed

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

mnriem commented Oct 21, 2026 •

edited

Loading