Create a fresh copy of the base repository config #795
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
klutchell
force-pushed
the
kyle/new-base-repo-object
branch
from
b6edc69 to
287522a
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR updates the repository configuration logic to create a fresh copy of the base repository config instead of referencing the original object.
- Uses Object.assign to shallow copy the base repository config
- Merges repository-specific properties into the fresh copy without mutating the original
klutchell
force-pushed
the
kyle/new-base-repo-object
branch
from
287522a to
352fddf
Compare
Avoid duplicating base repository settings when initializing repo config. Signed-off-by: Kyle Harding <[email protected]>
klutchell
force-pushed
the
kyle/new-base-repo-object
branch
from
352fddf to
b082cd5
Compare
|
@decyjphr this one fixed a bug for us where all repos were inheriting the repo name setting from a discovered repo called |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoid duplicating base repository settings when initializing repo config.