feat(extension): also allow .yaml file format #735
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @anderssonjohan and @decyjphr if you have time to have a look |
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for repository override configuration using the .yaml file format in addition to the existing .yml format.
- Updated retrieval of repo override configuration in lib/settings.js to support .yaml files.
- Added unit tests for both .yaml and .yml configurations in test/unit/lib/settings.test.js.
- README.md still incorrectly documents support only for the .yml extension.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| test/unit/lib/settings.test.js | Added tests to verify repository override configuration for .yaml files. |
| lib/settings.js | Updated repo override config lookup to include .yaml and modified its usage. |
| README.md | Documentation remains inconsistent with the code changes. |
Comments suppressed due to low confidence (1)
README.md:32
- Documentation conflicts with code changes; the code now supports .yaml files, but README indicates that .yaml is ignored.
Settings files must have a `.yml` extension only. For now, the `.yaml` extension is ignored.
Tip: Copilot code review supports C#, Go, Java, JavaScript, Markdown, Python, Ruby and TypeScript, with more languages coming soon. Learn more
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #700.