Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Catch review comments with no valid user #326

Merged
merged 1 commit into from
Jun 25, 2024
Merged

fix: Catch review comments with no valid user #326

merged 1 commit into from
Jun 25, 2024

Conversation

zkoppert
Copy link
Member

@zkoppert zkoppert commented Jun 25, 2024

Pull Request

Proposed Changes

related to #325. This PR handles the same issue as the previous PR, but this time it catches review comments (previous pr handled generic comments not attached to a review) with no valid user. This is important because it prevents the code from breaking when a review contains a ghost user.

Readiness Checklist

Author/Contributor

  • If documentation is needed for this change, has that been included in this pull request
  • run make lint and fix any issues that you have introduced
  • run make test and ensure you have test coverage for the lines you are introducing
  • If publishing new data to the public (scorecards, security scan results, code quality results, live dashboards, etc.), please request review from @jeffrey-luszcz

Reviewer

  • Label as either fix, documentation, enhancement, infrastructure, maintenance, or breaking

@zkoppert zkoppert merged commit 644aab8 into main Jun 25, 2024
28 checks passed
@zkoppert zkoppert deleted the ghost-users branch June 25, 2024 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants