Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: issue accessing repo when not provided in query #291

Merged
merged 1 commit into from
May 24, 2024

Conversation

jmeridth
Copy link
Member

Fixes #290

Pull Request

Proposed Changes

  • handle trying to access repository from dictionary when not present (use default of empty string)
  • add test to ensure we cover this scenario
  • renamed other test to match not testing repository present
  • handle issue where total_time_to_close variable was being access before possibly being declared
    • caught by linting locally (E0606: Possibly using variable 'total_time_to_close' before assignment (possibly-used-before-assignment))

Readiness Checklist

Author/Contributor

  • If documentation is needed for this change, has that been included in this pull request
  • run make lint and fix any issues that you have introduced
  • run make test and ensure you have test coverage for the lines you are introducing

Reviewer

  • Label as either fix, documentation, enhancement, infrastructure, maintenance, or breaking

@jmeridth jmeridth self-assigned this May 23, 2024
@jmeridth jmeridth requested a review from zkoppert as a code owner May 23, 2024 21:02
@github-actions github-actions bot added the fix label May 23, 2024
Fixes #290

- [x] handle trying to access repository from dictionary when not present (use default of empty string)
- [x] add test to ensure we cover this scenario
- [x] handle issue where `time_to_close` variable was being access before possibly being declared

Signed-off-by: jmeridth <[email protected]>
@jmeridth jmeridth merged commit 0926cff into main May 24, 2024
27 checks passed
@jmeridth jmeridth deleted the jm-search-query-bugs branch May 24, 2024 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

With org: or owner: in SEARCH_QUERY the action fails
2 participants