Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: release on specific labels #262

Merged
merged 1 commit into from
Apr 30, 2024
Merged

Conversation

jmeridth
Copy link
Member

@jmeridth jmeridth commented Apr 30, 2024

Related to github/github-ospo#105

Closes #255
Closes #259

Pull Request

Proposed Changes

Only generate a release and new action container images if our semver related labels (breaking, enhancement, fix) or the release label are used on a merged pull request.

Changed from push (merge) on main branch to release generation happening when a pull_request is merged to main branch.

This gives us access to the pull requests labels without having to make API cals.

Currently we'd still need to label a pull request with release if it is a dependabot or manual pull request related to a CVE or security fix.

  • update CONTRIBUTING.md with new release information
  • manually add vuln and release labels to repository

Readiness Checklist

Author/Contributor

  • If documentation is needed for this change, has that been included in this pull request
  • run make lint and fix any issues that you have introduced
  • run make test and ensure you have test coverage for the lines you are introducing

Reviewer

  • Label as either fix, documentation, enhancement, infrastructure, maintenance, or breaking

@jmeridth jmeridth self-assigned this Apr 30, 2024
@jmeridth jmeridth requested a review from zkoppert as a code owner April 30, 2024 06:17
Related to github/github-ospo#105

Only generate a release and new action container images if our semver related labels (`breaking`, `enhancement`, `fix`) or the `release` label are used on a merged pull request.

Changed from push (merge) on main branch to release generation happening when a pull_request is merged to main branch.

This gives us access to the pull requests labels without having to make API cals.

Currently we'd still need to label a pull request with `release` if it is a dependabot or manual pull request related to a CVE or security fix.

- [x] update CONTRIBUTING.md with new release information
- [x] manually add `vuln` and `release` labels to repository
- [x] add dependabot updates

Signed-off-by: jmeridth <[email protected]>
@jmeridth jmeridth force-pushed the jm-specific-labels-for-releases branch from 3b5cfd4 to 68a633a Compare April 30, 2024 16:44
@jmeridth jmeridth added enhancement New feature or request and removed feature labels Apr 30, 2024
@jmeridth jmeridth merged commit f923cf7 into main Apr 30, 2024
28 checks passed
@jmeridth jmeridth deleted the jm-specific-labels-for-releases branch April 30, 2024 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant