Use typed IconTheme constants from Go SDK #1675
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace string conversions with mcp.IconThemeLight and mcp.IconThemeDark constants to match the SDK's typed IconTheme field. This fixes the CI build errors where string literals were being used instead of the proper IconTheme type. Co-authored-by: SamMorrowDrums <[email protected]>
SamMorrowDrums
approved these changes
Dec 22, 2025
Copilot
AI
changed the title
[WIP] Update icon theme using typed strings from Go SDK
Use typed IconTheme constants from Go SDK
Dec 22, 2025
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the octicons package to use typed string constants from the MCP Go SDK instead of manual string conversions, improving type safety and consistency with the SDK's API.
- Replaced manual string conversions
string(ThemeLight)andstring(ThemeDark)with SDK constants - Updated test assertions to use typed constants instead of string literals
- No functional changes, only improved type safety
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| pkg/octicons/octicons.go | Updated Icons() function to use mcp.IconThemeLight and mcp.IconThemeDark constants directly instead of converting local Theme constants to strings |
| pkg/octicons/octicons_test.go | Updated test assertions to use typed mcp.IconThemeLight and mcp.IconThemeDark constants instead of string literals, and added import for the mcp package |
SamMorrowDrums
merged commit 110be36
into
dependabot/go_modules/github.com/modelcontextprotocol/go-sdk-1.2.0
19 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Replace string conversions with
mcp.IconThemetyped constants to match SDK v1.2.0's type system.Why
The Go SDK defines
IconThemeas a typed string with constantsIconThemeLightandIconThemeDark. Using string conversions caused type errors in CI.What changed
mcp.IconThemeLightandmcp.IconThemeDarkinpkg/octicons/octicons.gopkg/octicons/octicons_test.goto expect typed constantsMCP impact
Prompts tested (tool changes only)
N/A
Security / limits
Lint & tests
./script/lint./script/testDocs
Original prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.