Implement symmetric text padding from edges

[mkhuzaima]

Username and year are now have same padding from the edges. Padding is kept 5% for now, and, is customizable.

I have used alignment alongwith DrawStringWrapped method, to align username and year on the left and right side of gg.Context respectively.

Fixes #12.

[Copilot]

Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.

[chrisreddington]

Thanks @mkhuzaima for the contribution, it's appreciated! ✨ And your patience for me to review!

I've been taking a look through, and it looks like a great start! I've been thinking about an additional tweak that could be made (I realised I wasn't as clear as I could have been in my original issue!)

I think we're looking to balance the space between the Invertocat on the left hand edge with the text on the right hand edge. In the current implementation, the distance between left edge and username is the same as the right edge and year, it looks a little unbalanced compared to the left hand side.

So perhaps something like, the distances between these items should be the same:

1. Left edge to the left of the invertocat logo
2. Right of the invertocat logo to the left of the username
3. Right of the year text to the right edge

What do you think? 😄

[mkhuzaima]

Thanks @mkhuzaima for the contribution, it's appreciated! ✨ And your patience for me to review!

I've been taking a look through, and it looks like a great start! I've been thinking about an additional tweak that could be made (I realised I wasn't as clear as I could have been in my original issue!)

I think we're looking to balance the space between the Invertocat on the left hand edge with the text on the right hand edge. In the current implementation, the distance between left edge and username is the same as the right edge and year, it looks a little unbalanced compared to the left hand side.

So perhaps something like, the distances between these items should be the same:

1. Left edge to the left of the invertocat logo
2. Right of the invertocat logo to the left of the username
3. Right of the year text to the right edge

What do you think? 😄

Thanks so much for reviewing my contribution and for the thoughtful feedback—I really appreciate it! 😊

I see what you mean about balancing the spacing to make it feel more consistent. That’s a great idea, and I’ll work on tweaking it to align better with what you described. I’ll update the PR as soon as I’ve got it sorted!

Thanks again for your time and guidance—it’s been great working on this!

[Copilot]

Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.

[chrisreddington]

Hey @mkhuzaima, hope you're doing good! Just wanted to check in on how you're progressing, and if you need anything from me at all? Please let me know when you'd like another review 😄

[mkhuzaima]

Hey @mkhuzaima, hope you're doing good! Just wanted to check in on how you're progressing, and if you need anything from me at all? Please let me know when you'd like another review 😄

@chrisreddington I have updated the PR with the changes suggested and would appreciate it if you could review them at your convenience.

[chriswblake]

I think this might have been incidentally solved with #69. That PR also introduced left/right justification.

In stl/geometry/text.go:

• line 19 sets the the logo to a left offset of 3%.
• line 26/27 sets the year justification to right with a left offset of 97%. (a bit odd, but the same as a right offset of 3%)

[mkhuzaima]

I think this might have been incidentally solved with #69. That PR also introduced left/right justification.

In stl/geometry/text.go:

• line 19 sets the the logo to a left offset of 3%.
• line 26/27 sets the year justification to right with a left offset of 97%. (a bit odd, but the same as a right offset of 3%)

@chriswblake does that PR also implement the same spacing between logo and username?

[chriswblake]

@mkhuzaima,

Yes and no, but I think it is ok. The spacing between the logo and username is fixed and pretty close to the other distances.

In the below images, you can see the spacing isn't quite perfect, but I don't think anyone will notice 0.6mm difference. If we are really annoyed by it, we could easily increase the left distance of the username to get the 4.3mm.

The logo is fixed at 3% from the left (4.3mm).
The year is fixed at 3% from the right (4.6mm). I'm guessing they aren't perfectly the same because of the pixelation introducing a bit of error.

The username is fixed at 10% from the left (14.6mm).
The logo width is controlled by a scaling factor (40%), not a width factor, coming out to 6.7mm.

So the distance between the logo and username is fixed (3.7mm). It's not 4.3mm but I don't think anyone will visually notice 0.6mm.

[mkhuzaima]

@chriswblake By applying symmetric padding, it can easily be adjusted to any percentage, not necessarily 3. Just change in one constant will reflect changes at 3 places, and later, it can be taken from the user as well. I think the primary purpose of this PR was to make padding symmetric. If the distance will always be 3%, then, the current implementation is good, and this PR doesn't add any more value. But, I

@chrisreddington what are your thoughts?

[chrisreddington]

I think with the refactors from #69, the majority of the needs have been solved here. The approach has changed enough in that PR that we'd probably need a fresh PR/new approach if we did want to fix any nitpicks (e.g. spacing between the logo/username).

But I think the PR solves the main challenges that were being brought up, so we can close this PR for now 😄 Thanks again for jumping in here though @mkhuzaima! 🙏

[mkhuzaima]

I think with the refactors from #69, the majority of the needs have been solved here. The approach has changed enough in that PR that we'd probably need a fresh PR/new approach if we did want to fix any nitpicks (e.g. spacing between the logo/username).

But I think the PR solves the main challenges that were being brought up, so we can close this PR for now 😄 Thanks again for jumping in here though @mkhuzaima! 🙏

No problem. 😊