Add CLI parameters for move-tables feature - #1702
Merged
Merged
Conversation
danieljoos
added
the
feature-move-tables
Contributor
There was a problem hiding this comment.
Pull request overview
This PR introduces initial scaffolding for the “move-tables” feature by adding new CLI flags and a new migrator entrypoint intended to run a move-tables workflow.
Changes:
- Add
--move-tablesand target connection flags (--target-host,--target-port,--target-user,--target-password,--target-database) to the CLI. - Add
MigrationContext.MoveTablesplusIsMoveTablesMode()to switch execution into the move-tables path. - Add a new
Migrator.MoveTables()method and route execution to it when move-tables mode is enabled.
Show a summary per file
| File | Description |
|---|---|
| go/logic/migrator.go | Adds a new MoveTables() workflow entrypoint (currently incomplete and missing required initialization/cutover). |
| go/cmd/gh-ost/main.go | Adds CLI flags + validation and routes execution to MoveTables() when enabled. |
| go/base/context.go | Adds move-tables configuration fields to MigrationContext and a helper to detect the mode. |
Copilot's findings
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Files reviewed: 3/3 changed files
- Comments generated: 8
zacharysierakowski
approved these changes
Jun 10, 2026
ericyan
pushed a commit
that referenced
this pull request
Jul 31, 2026
Add move-table command parsing and validate the table-list input before initializing migration context. Refs: #1702
ericyan
pushed a commit
that referenced
this pull request
Jul 31, 2026
Add move-table command parsing and validate the table list input. Initialize migration context from the CLI configuration. Refs: #1702
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A Pull Request should be associated with an Issue.
Related issue (public): #1681
Related issue (internal): https://github.com/github/database-infrastructure/issues/8167
Description
This PR is part of the move-tables feature.
It introduces CLI flags for enabling the move-tables mode and to specify the destination database.
script/cibuildreturns with no formatting errors, build errors or unit test errors.