Skip to content

Security Fix: Prevent path traversal in shell completion config file reads (Alerts #444, #443) #8699

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pelikhan merged 1 commit into from
Jan 3, 2026
Merged

Security Fix: Prevent path traversal in shell completion config file reads (Alerts #444, #443) #8699

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 16 additions & 2 deletions pkg/cli/shell_completion.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -197,7 +197,14 @@ func installBashCompletion(verbose bool, cmd *cobra.Command) error {
bashrcPath := filepath.Join(homeDir, ".bashrc")
if strings.HasPrefix(completionPath, homeDir) {
// For user-level installations, check if .bashrc sources the completion directory
bashrcContent, err := os.ReadFile(bashrcPath)
// Clean and validate the path to prevent path traversal
cleanBashrcPath := filepath.Clean(bashrcPath)
if !filepath.IsAbs(cleanBashrcPath) {
shellCompletionLog.Printf("Invalid bashrc path (not absolute): %s", bashrcPath)
return fmt.Errorf("invalid bashrc path: %s", bashrcPath)
}
// #nosec G304 -- bashrcPath is constructed from trusted os.UserHomeDir() and a constant filename
bashrcContent, err := os.ReadFile(cleanBashrcPath)
needsSourceLine := true
if err == nil {
if strings.Contains(string(bashrcContent), ".bash_completion.d") ||
Expand Down Expand Up @@ -262,7 +269,14 @@ func installZshCompletion(verbose bool, cmd *cobra.Command) error {

// Check if .zshrc configures fpath
zshrcPath := filepath.Join(homeDir, ".zshrc")
zshrcContent, err := os.ReadFile(zshrcPath)
// Clean and validate the path to prevent path traversal
cleanZshrcPath := filepath.Clean(zshrcPath)
if !filepath.IsAbs(cleanZshrcPath) {
shellCompletionLog.Printf("Invalid zshrc path (not absolute): %s", zshrcPath)
return fmt.Errorf("invalid zshrc path: %s", zshrcPath)
}
// #nosec G304 -- zshrcPath is constructed from trusted os.UserHomeDir() and a constant filename
zshrcContent, err := os.ReadFile(cleanZshrcPath)
needsFpath := true
if err == nil {
if strings.Contains(string(zshrcContent), userCompletionDir) {
Expand Down