Move noop processing step from separate job into conclusion job

[Copilot]

Move noop processing step from separate job into conclusion job

Consolidates workflow structure by generating the noop JavaScript step inside the conclusion job instead of as a separate job.

Changes

• pkg/workflow/notify_comment.go: Added noop step generation to buildConclusionJob(), including environment variables, script invocation, and noop_message output. Artifact download steps are now added once at the beginning and shared by both noop and conclusion steps.
• pkg/workflow/compiler_jobs.go: Removed noop job creation code; noop no longer added to safeOutputJobNames
• pkg/workflow/noop.go: Removed unused buildCreateOutputNoOpJob() function
• pkg/workflow/safe_outputs.go: Added buildGitHubScriptStepWithoutDownload() helper function for building script steps without duplicate artifact downloads
• pkg/workflow/noop_in_conclusion_test.go: Added test validating noop step appears in conclusion job with correct outputs and dependencies

Structure Change

Before:

jobs:
  agent: ...
  noop:
    needs: [agent]
    steps:
      - name: Download artifact
      - name: Process No-Op Messages
  conclusion:
    needs: [agent, noop]
    steps:
      - name: Download artifact
      - name: Update reaction comment

After:

jobs:
  agent: ...
  conclusion:
    needs: [agent]
    steps:
      - name: Download artifact (shared)
      - name: Process No-Op Messages
      - name: Update reaction comment

The noop processing logic and JavaScript remain unchanged—only the job structure is simplified and artifact downloads are no longer duplicated.

Fix Details

Fixed duplicate artifact download issue where both the noop step and the conclusion step were independently adding artifact download steps. Now:

• Artifact download steps are added once at the beginning of the conclusion job
• Created buildGitHubScriptStepWithoutDownload() helper for subsequent steps
• Both noop and conclusion steps share the same downloaded artifact
• Reduces workflow execution time and resource usage

Original prompt

Update the compiler to generate the noop javascript step inside of the conclusion job instead of the noop job.

• generate noop javascript step inside of conclusion job
• remove noop job

---

💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

[Copilot]

Pull Request Overview

This PR refactors the noop (no-operation) processing by consolidating it into the conclusion job, eliminating a separate noop job. This simplifies the workflow structure while maintaining all functionality.

Key changes:

• Noop step generation moved to buildConclusionJob in notify_comment.go
• Removed noop job generation code from compiler_jobs.go
• Added comprehensive test coverage in noop_in_conclusion_test.go

Reviewed Changes

Copilot reviewed 74 out of 74 changed files in this pull request and generated 2 comments.

File	Description
pkg/workflow/notify_comment.go	Adds noop processing step to conclusion job with proper environment variables and outputs
pkg/workflow/compiler_jobs.go	Removes dedicated noop job generation code
pkg/workflow/noop_in_conclusion_test.go	Adds unit tests verifying noop step placement in conclusion job
.github/workflows/*.lock.yml	All compiled workflows updated with noop step now in conclusion job

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

The noop step is placed after a 'Setup agent output environment variable' step, but then followed by another identical artifact download and setup at lines 4542-4552. This creates duplicate artifact downloads and environment setup. The noop step should be moved after the second artifact download/setup block to avoid running before artifacts are properly downloaded.

[pelikhan]

@copilot fix ordering of steps

[Copilot]

Duplicate artifact download and environment setup steps appear after the noop processing step. This redundancy suggests the noop step was inserted in the wrong location. These duplicate steps at lines 4542-4552 appear to be unnecessary since the same setup already occurred at lines 4448-4456 before the noop step.

[pelikhan]

@copilot avoid generate two artifact download steps for the same resource

[github-actions]

✅ Agentic Changeset Generator completed successfully.

[Copilot]

@copilot avoid generate two artifact download steps for the same resource

Fixed in d42afa8. The artifact download steps are now added once at the beginning of the conclusion job and shared by both the noop and conclusion steps. Created a new buildGitHubScriptStepWithoutDownload() helper function to avoid duplicating the artifact download in subsequent steps.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

• https://api.github.com/user
  • Triggering command: gh api user --jq .login (http block)

If you need me to access, download, or install something from one of these locations, you can either:

• Configure Actions setup steps to set up my environment, which run before the firewall is enabled
• Add the appropriate URLs or hosts to the custom allowlist in this repository's Copilot coding agent settings (admins only)

[pelikhan]

@copilot the conclusion job has duplicate steps to download and setup artifacts. Remove the later ones

[Copilot]

@copilot the conclusion job has duplicate steps to download and setup artifacts. Remove the later ones

The duplicate artifact download steps have already been removed in d42afa8. The conclusion job now has only one set of download/setup steps that are shared by both the noop and conclusion script steps. The current state shows:

1. Download agent output artifact (once)
2. Setup agent output environment variable (once)
3. Process No-Op Messages (uses the downloaded artifact)
4. Update reaction comment (uses the same downloaded artifact)

No further changes needed.