feat: support sandbox configuration via shared workflow imports#4299
Closed
Copilot wants to merge 2 commits intomossaka/srtfrom
Closed
feat: support sandbox configuration via shared workflow imports#4299Copilot wants to merge 2 commits intomossaka/srtfrom
Copilot wants to merge 2 commits intomossaka/srtfrom
Conversation
- Add `sandbox` field support to included_file_schema.json - Create shared/sandbox-runtime.md for sandbox-runtime configuration - Update smoke-srt.md to import sandbox config instead of using builtin field - Add sandbox extraction and merging in import processing - Update parser to extract MergedSandbox from imports - Update compiler to merge sandbox from imported files - Fix firewall test to pass nil sandboxConfig parameter Addresses feedback: sandbox should not be builtin, rather imported as shared workflow Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix feedback on copilot sandbox implementation
feat: support sandbox configuration via shared workflow imports
Nov 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses feedback to make sandbox configuration importable rather than requiring inline declaration in each workflow.
Changes
Schema: Added
sandboxfield toincluded_file_schema.jsonwith full configuration options (string enum or object with type/config)Shared workflow: Created
.github/workflows/shared/sandbox-runtime.mdcontainingsandbox: sandbox-runtimeconfigurationParser: Added sandbox extraction/merging logic to
ProcessImportsFromFrontmatterWithManifest()with newMergedSandboxfieldCompiler: Merge imported sandbox when top-level workflow doesn't define one (uses same pattern as network/permissions merging)
Migration: Updated
smoke-srt.mdfrom inlinesandbox: sandbox-runtimetoimports: [shared/sandbox-runtime.md]Example
Before:
After:
The shared workflow approach enables reusable sandbox configurations across multiple workflows while maintaining backward compatibility with inline declarations.
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.