Skip to content

Add close-discussion safe-output to daily-performance-summary workflow#40533

Merged
pelikhan merged 2 commits into
mainfrom
copilot/fix-missing-tools-in-workflow
Jun 21, 2026
Merged

Add close-discussion safe-output to daily-performance-summary workflow#40533
pelikhan merged 2 commits into
mainfrom
copilot/fix-missing-tools-in-workflow

Conversation

Copilot AI commented Jun 21, 2026

Copy link
Copy Markdown
Contributor

The daily performance summary workflow was instructed to close previous discussions in Phase 5, but close_discussion was never registered in safe-outputs — causing the agent to report it as a missing tool on every run.

Changes

  • .github/workflows/daily-performance-summary.md: Added close-discussion safe-output with required-title-prefix: "[daily performance] ", restricting it to only close discussions matching that prefix
  • .github/workflows/daily-performance-summary.lock.yml: Recompiled — close_discussion now appears in the agent's tool list and handler config
safe-outputs:
  upload-asset:
    max: 3
    allowed-exts: [.png, .jpg, .jpeg, .svg]
  close-discussion:
    required-title-prefix: "[daily performance] "

Matches the pattern used by daily-regulatory.md.

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Copilot AI changed the title [WIP] Fix missing tools in daily project performance summary generator Add close-discussion safe-output to daily-performance-summary workflow Jun 21, 2026
Copilot AI requested a review from pelikhan June 21, 2026 00:21
@github-actions github-actions Bot mentioned this pull request Jun 21, 2026
@pelikhan pelikhan marked this pull request as ready for review June 21, 2026 01:39
Copilot AI review requested due to automatic review settings June 21, 2026 01:39
@pelikhan pelikhan merged commit bda1fcd into main Jun 21, 2026
1 check passed
@pelikhan pelikhan deleted the copilot/fix-missing-tools-in-workflow branch June 21, 2026 01:39

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes a recurring runtime/tooling error in the daily-performance-summary agentic workflow by registering the missing close_discussion safe-output so the agent can close prior daily-performance discussions as originally intended.

Changes:

  • Added a close-discussion safe-output registration to the workflow frontmatter, gated by required-title-prefix: "[daily performance] " to prevent accidental closures.
  • Recompiled the workflow lockfile so close_discussion is included in the generated safe-outputs tool list and handler configuration.
Show a summary per file
File Description
.github/workflows/daily-performance-summary.md Registers close-discussion safe-output with a restrictive title-prefix gate.
.github/workflows/daily-performance-summary.lock.yml Recompiled output reflecting the new close_discussion tool, validation schema, and handler config.

Copilot's findings

Tip

Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

  • Files reviewed: 2/2 changed files
  • Comments generated: 0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants