Skip to content

[instructions] Sync instruction files: client-id preferred, Serena migration#30968

Merged
pelikhan merged 1 commit intomainfrom
instructions/sync-client-id-serena-fixes-c961e18738a42aa7
May 8, 2026
Merged

[instructions] Sync instruction files: client-id preferred, Serena migration#30968
pelikhan merged 1 commit intomainfrom
instructions/sync-client-id-serena-fixes-c961e18738a42aa7

Conversation

@github-actions
Copy link
Copy Markdown
Contributor

@github-actions github-actions Bot commented May 8, 2026

Instructions Update

This PR updates instruction files in .github/aw/ based on a code audit against the latest changesets.

Files Changed

  • syntax.md: Replace app-id: with client-id: in on.github-app and tools.github.github-app sections. The JSON schema marks app-id as a deprecated alias; client-id is the preferred field. Note app-id: as legacy alias.
  • safe-outputs.md: Same app-id: to client-id: update in the safe-outputs.github-app section.
  • github-mcp-server.md: Fix incorrect YAML structure — app-id/private-key were placed directly under tools.github instead of under the required github-app: nesting. Updated to use client-id:.
  • serena-tool.md: tools.serena has been removed from the schema. Replaced all configuration examples with the correct imports: uses: shared/mcp/serena.md with: languages: [...] syntax.

Code Evidence

  • pkg/parser/schemas/main_workflow_schema.json: app-id marked as Deprecated alias for client-id
  • pkg/workflow/safe_outputs_app_config.go: Prefer client-id when both are provided; app-id is accepted for backward compatibility.
  • pkg/parser/schemas/main_workflow_schema.json: tools.serena marked REMOVED: Built-in support for Serena has been removed. Use the shared/mcp/serena.md workflow instead.

Size Audit

File Lines Status
github-agentic-workflows.md 193 ✓ (< 250)
syntax.md 940 ✓ (< 1000)
safe-outputs.md 994 ✓ (< 1000)
serena-tool.md 182
github-mcp-server.md 369

Validation

  • Imperative mood, minimal examples
  • Technical tone, brevity maintained
  • Each change routed to the correct sub-file
  • No content duplication introduced
  • File sizes within target limits
  • Verified accuracy against current codebase (schema + Go sources)

Generated by Instructions Janitor · ● 806.7K ·

  • expires on May 10, 2026, 9:05 AM UTC

…gration

- Replace deprecated `app-id:` with `client-id:` in all github-app examples
  (syntax.md, safe-outputs.md, github-mcp-server.md); mention app-id as
  legacy alias per schema deprecation marker
- Fix github-mcp-server.md: move app credentials under proper github-app:
  nesting (was incorrectly placed at tools.github level)
- Update serena-tool.md: tools.serena has been removed; replace all
  examples with imports: uses: shared/mcp/serena.md with: languages: [...]

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@pelikhan pelikhan merged commit 4043b0b into main May 8, 2026
@pelikhan pelikhan deleted the instructions/sync-client-id-serena-fixes-c961e18738a42aa7 branch May 8, 2026 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

automation documentation Improvements or additions to documentation instructions

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant