fix: remove redundant double type assertion in validateMCPRequirements

[Copilot]

validateMCPRequirements performed two type assertions on the same value: one to check, one to extract. The second assertion was safe but non-idiomatic and misleading.

Change

Collapsed the two-step pattern into a single canonical Go assertion:

// Before
if _, ok := mcpType.(string); !ok {
    return fmt.Errorf(...)
}
typeStr = mcpType.(string)

// After
var ok bool
typeStr, ok = mcpType.(string)
if !ok {
    return fmt.Errorf(...)
}

[Copilot]

Pull request overview

This PR simplifies MCP config validation in Go by removing a redundant double type assertion when reading the type field, and also includes broad updates to generated workflow lock files (mostly adjusting actions/github-script version annotations / manifest metadata).

Changes:

• Collapse the two-step mcpType.(string) check+extract into a single assertion assignment in validateMCPRequirements.
• Update multiple .github/workflows/*.lock.yml generated lock files, primarily changing actions/github-script version annotation strings (e.g., v9.0.0 → v9) in the embedded manifest/headers and some uses: comments.

Show a summary per file

File	Description
pkg/workflow/mcp_property_validation.go	Removes redundant double type assertion when validating explicit MCP type.
.github/workflows/weekly-editors-health-check.lock.yml	Updates generated lock header/manifest and actions/github-script version annotation.
.github/workflows/video-analyzer.lock.yml	Updates generated lock header/manifest and actions/github-script version annotation.
.github/workflows/update-astro.lock.yml	Updates generated lock header/manifest and actions/github-script version annotation.
.github/workflows/test-workflow.lock.yml	Updates generated lock header/manifest and actions/github-script version annotation.
.github/workflows/test-project-url-default.lock.yml	Updates generated lock header/manifest and actions/github-script version annotation.
.github/workflows/test-dispatcher.lock.yml	Updates generated lock header/manifest and actions/github-script version annotation.
.github/workflows/smoke-workflow-call.lock.yml	Updates generated lock header/manifest and actions/github-script version annotation.
.github/workflows/smoke-workflow-call-with-inputs.lock.yml	Updates generated lock header/manifest and actions/github-script version annotation.
.github/workflows/smoke-temporary-id.lock.yml	Updates generated lock header/manifest and actions/github-script version annotation.
.github/workflows/smoke-service-ports.lock.yml	Updates generated lock header/manifest and actions/github-script version annotation.
.github/workflows/smoke-opencode.lock.yml	Updates generated lock header/manifest and actions/github-script version annotation.
.github/workflows/smoke-crush.lock.yml	Updates generated lock header/manifest and actions/github-script version annotation.
.github/workflows/smoke-ci.lock.yml	Updates generated lock header/manifest and actions/github-script version annotation.
.github/workflows/research.lock.yml	Updates generated lock header/manifest and actions/github-script version annotation.
.github/workflows/repo-tree-map.lock.yml	Updates generated lock header/manifest and actions/github-script version annotation.
.github/workflows/github-remote-mcp-auth-test.lock.yml	Updates generated lock header/manifest and actions/github-script version annotation.
.github/workflows/github-mcp-tools-report.lock.yml	Updates generated lock header/manifest and actions/github-script version annotation.
.github/workflows/functional-pragmatist.lock.yml	Updates generated lock header/manifest and actions/github-script version annotation.
.github/workflows/firewall.lock.yml	Updates generated lock header/manifest and actions/github-script version annotation.
.github/workflows/example-permissions-warning.lock.yml	Updates generated lock header/manifest and actions/github-script version annotation.
.github/workflows/docs-noob-tester.lock.yml	Updates generated lock header/manifest and actions/github-script version annotation.
.github/workflows/dependabot-repair.lock.yml	Updates generated lock header/manifest and actions/github-script version annotation.
.github/workflows/dependabot-go-checker.lock.yml	Updates generated lock header/manifest and actions/github-script version annotation.
.github/workflows/dependabot-burner.lock.yml	Updates generated lock header/manifest and actions/github-script version annotation.
.github/workflows/daily-team-status.lock.yml	Updates generated lock header/manifest and actions/github-script version annotation.
.github/workflows/daily-team-evolution-insights.lock.yml	Updates generated lock header/manifest and actions/github-script version annotation.
.github/workflows/daily-syntax-error-quality.lock.yml	Updates generated lock header/manifest and actions/github-script version annotation.
.github/workflows/daily-sentrux-report.lock.yml	Updates generated lock header/manifest and actions/github-script version annotation.
.github/workflows/daily-regulatory.lock.yml	Updates generated lock header/manifest and actions/github-script version annotation.
.github/workflows/daily-multi-device-docs-tester.lock.yml	Updates generated lock header/manifest and actions/github-script version annotation.
.github/workflows/daily-malicious-code-scan.lock.yml	Updates generated lock header/manifest and actions/github-script version annotation.
.github/workflows/codex-github-remote-mcp-test.lock.yml	Updates generated lock header/manifest and actions/github-script version annotation.
.github/workflows/code-simplifier.lock.yml	Updates generated lock header/manifest and actions/github-script version annotation.
.github/workflows/cli-consistency-checker.lock.yml	Updates generated lock header/manifest and actions/github-script version annotation.
.github/workflows/changeset.lock.yml	Updates generated lock header/manifest and actions/github-script version annotation.
.github/workflows/blog-auditor.lock.yml	Updates generated lock header/manifest and actions/github-script version annotation.
.github/workflows/ace-editor.lock.yml	Updates generated lock header/manifest and actions/github-script version annotation (including a job step use).

Copilot's findings

Tip

Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

• Files reviewed: 152/187 changed files
• Comments generated: 1