[fp-enhancer] Improve pkg/actionpins: eliminate mutable shortSHA variable

[github-actions]

Summary

Applies a tasteful immutability improvement to pkg/actionpins as part of a round-robin functional-programming enhancement pass.

Change

In countPinKeyMismatches, the shortSHA variable was declared mutable and conditionally reassigned:

// Before
shortSHA := pin.SHA
if len(pin.SHA) > 8 {
    shortSHA = pin.SHA[:8]
}

Replaced with a single immutable declaration using Go's built-in min function (available since Go 1.21):

// After
shortSHA := pin.SHA[:min(len(pin.SHA), 8)]

Benefits

• Immutability: Variable is now initialized once and never reassigned
• Clarity: Intent is immediately obvious — take at most 8 chars
• Conciseness: 4 lines → 1 line

Round-Robin Progress

• Processed: pkg/actionpins (first package in cycle)
• Next run: pkg/agentdrain

Validation

• make build passes
• make fmt passes
• TestCountPinKeyMismatches_ReturnsOnlyVersionMismatches passes
• No behaviour changes

References: §25489567849

Generated by Functional Pragmatist · ● 7.7M · ◷

• expires on May 8, 2026, 10:17 AM UTC

[Copilot]

Pull request overview

This PR refactors countPinKeyMismatches in pkg/actionpins to compute a shortened SHA without using a mutable local variable, relying on Go’s built-in min to slice to at most 8 characters.

Changes:

• Replaces a conditional reassignment of shortSHA with a single immutable slice expression.
• Keeps the warning log output behavior equivalent while simplifying the code path.

Show a summary per file

File	Description
pkg/actionpins/actionpins.go	Makes shortSHA initialization immutable by slicing to min(len(pin.SHA), 8) before logging key/version mismatch warnings.

Copilot's findings

Tip

Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

• Files reviewed: 1/1 changed files
• Comments generated: 0

[github-actions]

🧠 Reviewed using Matt Pocock's skills by Matt Pocock Skills Reviewer · ● 1.6M