[log] Add debug logging to 5 workflow pkg files#30747
Merged
Conversation
Adds meaningful debug log calls to branches and functions that previously had no visibility when running with DEBUG=workflow:*. Files changed: - runtime_overrides.go: log unknown runtime handling and new requirement creation - engine_api_targets.go: log entry and resolution path for GetCopilotAPITarget/GetGeminiAPITarget - slash_command_parser.go: log expandSlashCommandShorthand expansion - label_trigger_parser.go: log non-matching patterns and getItemTypeName result - service_ports.go: log parsePortSpec entry, port range parsing, and protocol skips Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds meaningful debug log calls to code paths that previously had no visibility under
DEBUG=workflow:*.Changes
pkg/workflow/runtime_overrides.goRuntimeRequirementfrom a known runtimeaction-repospecifiedpkg/workflow/engine_api_targets.goGetCopilotAPITarget: entry log + log which resolution path is taken (explicitapi-targetvs. derived fromGITHUB_COPILOT_BASE_URL)GetGeminiAPITarget: entry log + log which path is taken (customGEMINI_API_BASE_URL, default endpoint, or empty)pkg/workflow/slash_command_parser.goexpandSlashCommandShorthand: log the expansion (/command→slash_command + workflow_dispatch)pkg/workflow/label_trigger_parser.goparseLabelTriggerShorthand: log when input does not match any label trigger patterngetItemTypeName: log the resolved human-readable type namepkg/workflow/service_ports.goparsePortSpec: log entry with spec value and typeTesting
All changes follow the established logger patterns for each file. The
make buildtarget fails in this environment due to a pre-existing Go toolchain version mismatch (go.modrequires 1.25.8, environment has 1.24.13 withGOTOOLCHAIN=local). The changes are syntactically valid additions oflog.Print/log.Printfcalls using pre-existing logger variables.