[dead-code] chore: remove dead functions — 1 function removed#30639
Merged
[dead-code] chore: remove dead functions — 1 function removed#30639
Conversation
Remove unreachable exported function ValidateAWFConfigJSON, which is a thin wrapper around validateAWFConfigJSON with no callers outside of its own definition. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Contributor
Author
There was a problem hiding this comment.
Skills-Based Review 🧠
Applied /zoom-out — appropriate for a cleanup/dead-code removal PR.
Summary
This PR removes a single exported wrapper function ValidateAWFConfigJSON that delegated directly to the unexported validateAWFConfigJSON. Per the DEADCODE.md tracking file, this is a routine hygiene change.
Verdict
✅ Clean, minimal change. The unexported function remains and the exported wrapper added no value beyond what callers could not access internally. No issues found.
Positive Highlights
- ✅ No logic change — purely removing an indirection layer
- ✅ Consistent with the project's
DEADCODE.mddead-code tracking practice - ✅ The removed comment accurately described why the export existed; removing both together keeps the codebase clean
🧠 Reviewed using Matt Pocock's skills by Matt Pocock Skills Reviewer · ● 1.1M
This was referenced May 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dead Code Removal
This PR removes unreachable Go functions identified by the
deadcodestatic analyzer.Functions Removed
ValidateAWFConfigJSONpkg/workflow/awf_config.goTests Removed
None.
Verification
go build ./...— passesgo vet ./...— passesgo vet -tags=integration ./...— passesmake fmt— no changes neededDead Function Count
Automated by Dead Code Removal workflow — https://github.com/github/gh-aw/actions/runs/25443535713