feat: Update OTel instrumentation workflow to support multiple endpoints#30309
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
…nges Agent-Logs-Url: https://github.com/github/gh-aw/sessions/da5a4519-4566-41a2-bfa0-3a8a9252e468 Co-authored-by: mnkiefer <8320933+mnkiefer@users.noreply.github.com>
…f47b87 Agent-Logs-Url: https://github.com/github/gh-aw/sessions/da5a4519-4566-41a2-bfa0-3a8a9252e468 Co-authored-by: mnkiefer <8320933+mnkiefer@users.noreply.github.com>
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Pull request overview
Updates the OTel workflow configuration to introduce separate Sentry/Grafana secrets across generated workflow lockfiles, switches the Grafana MCP server doc to entrypointArgs, and attempts to add multi-endpoint OTLP support in shared workflow imports.
Changes:
- Replaced legacy
GH_AW_OTEL_ENDPOINT/GH_AW_OTEL_HEADERSsecrets in many generated workflow lockfiles with separate Sentry and Grafana endpoint/header secrets. - Updated shared OTel docs/imports, including
shared/otel.mdandshared/observability-otlp.md. - Renamed the Grafana MCP container argument field from
argstoentrypointArgsin the source workflow doc.
Show a summary per file
| File | Description |
|---|---|
.github/workflows/weekly-issue-summary.lock.yml |
Regenerated workflow env/secrets for split OTel endpoints. |
.github/workflows/typist.lock.yml |
Regenerated workflow env/secrets for split OTel endpoints. |
.github/workflows/terminal-stylist.lock.yml |
Regenerated workflow env/secrets for split OTel endpoints. |
.github/workflows/stale-repo-identifier.lock.yml |
Regenerated workflow env/secrets for split OTel endpoints. |
.github/workflows/smoke-pi.lock.yml |
Regenerated workflow env/secrets for split OTel endpoints. |
.github/workflows/smoke-opencode.lock.yml |
Regenerated workflow env/secrets for split OTel endpoints. |
.github/workflows/smoke-gemini.lock.yml |
Regenerated workflow env/secrets for split OTel endpoints. |
.github/workflows/shared/otel.md |
Updated shared OTel secret documentation. |
.github/workflows/shared/observability-otlp.md |
Changed shared OTLP frontmatter from single endpoint to multi-endpoint structure. |
.github/workflows/sergo.lock.yml |
Regenerated workflow env/secrets for split OTel endpoints. |
.github/workflows/schema-consistency-checker.lock.yml |
Regenerated workflow env/secrets for split OTel endpoints. |
.github/workflows/repository-quality-improver.lock.yml |
Regenerated workflow env/secrets for split OTel endpoints. |
.github/workflows/repo-audit-analyzer.lock.yml |
Regenerated workflow env/secrets for split OTel endpoints. |
.github/workflows/lockfile-stats.lock.yml |
Regenerated workflow env/secrets for split OTel endpoints. |
.github/workflows/github-remote-mcp-auth-test.lock.yml |
Regenerated workflow env/secrets for split OTel endpoints. |
.github/workflows/github-mcp-tools-report.lock.yml |
Regenerated workflow env/secrets for split OTel endpoints. |
.github/workflows/github-mcp-structural-analysis.lock.yml |
Regenerated workflow env/secrets for split OTel endpoints. |
.github/workflows/example-workflow-analyzer.lock.yml |
Regenerated workflow env/secrets for split OTel endpoints. |
.github/workflows/docs-noob-tester.lock.yml |
Regenerated workflow env/secrets for split OTel endpoints. |
.github/workflows/delight.lock.yml |
Regenerated workflow env/secrets for split OTel endpoints. |
.github/workflows/daily-token-consumption-report.lock.yml |
Regenerated workflow env/secrets for split OTel endpoints. |
.github/workflows/daily-team-status.lock.yml |
Regenerated workflow env/secrets for split OTel endpoints. |
.github/workflows/daily-team-evolution-insights.lock.yml |
Regenerated workflow env/secrets for split OTel endpoints. |
.github/workflows/daily-syntax-error-quality.lock.yml |
Regenerated workflow env/secrets for split OTel endpoints. |
.github/workflows/daily-sentrux-report.lock.yml |
Regenerated workflow env/secrets for split OTel endpoints. |
.github/workflows/daily-security-red-team.lock.yml |
Regenerated workflow env/secrets for split OTel endpoints. |
.github/workflows/daily-secrets-analysis.lock.yml |
Regenerated workflow env/secrets for split OTel endpoints. |
.github/workflows/daily-safe-outputs-conformance.lock.yml |
Regenerated workflow env/secrets for split OTel endpoints. |
.github/workflows/daily-safe-output-integrator.lock.yml |
Regenerated workflow env/secrets for split OTel endpoints. |
.github/workflows/daily-repo-chronicle.lock.yml |
Regenerated workflow env/secrets for split OTel endpoints. |
.github/workflows/daily-regulatory.lock.yml |
Regenerated workflow env/secrets for split OTel endpoints. |
.github/workflows/daily-performance-summary.lock.yml |
Regenerated workflow env/secrets for split OTel endpoints. |
.github/workflows/daily-otel-instrumentation-advisor.lock.yml |
Regenerated workflow env/secrets for split OTel endpoints. |
.github/workflows/daily-news.lock.yml |
Regenerated workflow env/secrets for split OTel endpoints. |
.github/workflows/daily-multi-device-docs-tester.lock.yml |
Regenerated workflow env/secrets for split OTel endpoints. |
.github/workflows/daily-malicious-code-scan.lock.yml |
Regenerated workflow env/secrets for split OTel endpoints. |
.github/workflows/daily-issues-report.lock.yml |
Regenerated workflow env/secrets for split OTel endpoints. |
.github/workflows/daily-grafana-otel-instrumentation-advisor.md |
Switched Grafana MCP config from args to entrypointArgs. |
.github/workflows/daily-geo-optimizer.lock.yml |
Regenerated workflow env/secrets for split OTel endpoints. |
.github/workflows/daily-experiment-report.lock.yml |
Regenerated workflow env/secrets for split OTel endpoints. |
.github/workflows/daily-doc-healer.lock.yml |
Regenerated workflow env/secrets for split OTel endpoints. |
.github/workflows/daily-code-metrics.lock.yml |
Regenerated workflow env/secrets for split OTel endpoints. |
.github/workflows/daily-cli-tools-tester.lock.yml |
Regenerated workflow env/secrets for split OTel endpoints. |
.github/workflows/daily-cli-performance.lock.yml |
Regenerated workflow env/secrets for split OTel endpoints. |
.github/workflows/daily-architecture-diagram.lock.yml |
Regenerated workflow env/secrets for split OTel endpoints. |
.github/workflows/copilot-session-insights.lock.yml |
Regenerated workflow env/secrets for split OTel endpoints. |
.github/workflows/copilot-pr-prompt-analysis.lock.yml |
Regenerated workflow env/secrets for split OTel endpoints. |
.github/workflows/copilot-pr-nlp-analysis.lock.yml |
Regenerated workflow env/secrets for split OTel endpoints. |
.github/workflows/copilot-pr-merged-report.lock.yml |
Regenerated workflow env/secrets for split OTel endpoints. |
.github/workflows/copilot-agent-analysis.lock.yml |
Regenerated workflow env/secrets for split OTel endpoints. |
.github/workflows/claude-code-user-docs-review.lock.yml |
Regenerated workflow env/secrets for split OTel endpoints. |
.github/workflows/blog-auditor.lock.yml |
Regenerated workflow env/secrets for split OTel endpoints. |
Copilot's findings
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Files reviewed: 102/102 changed files
- Comments generated: 2
Agent-Logs-Url: https://github.com/github/gh-aw/sessions/ce234218-efd5-4301-8605-8a5d4131c320 Co-authored-by: mnkiefer <8320933+mnkiefer@users.noreply.github.com>
… new secret names Agent-Logs-Url: https://github.com/github/gh-aw/sessions/5c0222d4-468d-4c74-941e-f5e8f0c5114b Co-authored-by: mnkiefer <8320933+mnkiefer@users.noreply.github.com>
|
@copilot resolve the merge conflicts by accepting current .lock.yml files over main ones. |
Co-authored-by: mnkiefer <8320933+mnkiefer@users.noreply.github.com>
|
Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details. Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
…compiler schema Agent-Logs-Url: https://github.com/github/gh-aw/sessions/ce234218-efd5-4301-8605-8a5d4131c320 Co-authored-by: mnkiefer <8320933+mnkiefer@users.noreply.github.com>
|
Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details. Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
# Conflicts: # .github/aw/github-agentic-workflows.md # .github/workflows/daily-astrostylelite-markdown-spellcheck.lock.yml # .github/workflows/daily-aw-cross-repo-compile-check.lock.yml # .github/workflows/daily-cache-strategy-analyzer.lock.yml # .github/workflows/daily-caveman-optimizer.lock.yml # .github/workflows/daily-fact.lock.yml # .github/workflows/daily-grafana-otel-instrumentation-advisor.lock.yml # .github/workflows/daily-hippo-learn.lock.yml # .github/workflows/daily-model-inventory.lock.yml # .github/workflows/daily-observability-report.lock.yml # .github/workflows/daily-skill-optimizer.lock.yml # .github/workflows/smoke-call-workflow.lock.yml # .github/workflows/smoke-codex.lock.yml Co-authored-by: mnkiefer <8320933+mnkiefer@users.noreply.github.com>
Resolved all merge conflicts with |
This comment has been minimized.
This comment has been minimized.
|
@copilot resolve conflicts by recompiling workflows. |
Agent-Logs-Url: https://github.com/github/gh-aw/sessions/e7ba02cc-0d53-46ad-917f-a7fd659039db Co-authored-by: mnkiefer <8320933+mnkiefer@users.noreply.github.com>
Recompiled all workflow lock files in commit Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
|
@copilot Resolve confligs by considering gitattributes: |
# Conflicts: # .github/workflows/daily-cache-strategy-analyzer.lock.yml # .github/workflows/daily-fact.lock.yml # .github/workflows/daily-observability-report.lock.yml # .github/workflows/smoke-call-workflow.lock.yml # .github/workflows/smoke-codex.lock.yml Co-authored-by: mnkiefer <8320933+mnkiefer@users.noreply.github.com>
…h merge=ours) Agent-Logs-Url: https://github.com/github/gh-aw/sessions/4d7792d1-191a-4ec5-a713-ab7cb15c83eb Co-authored-by: mnkiefer <8320933+mnkiefer@users.noreply.github.com>
Merged Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
|
@copilot revert changes to |
Agent-Logs-Url: https://github.com/github/gh-aw/sessions/6578897a-a79f-4e87-808f-7dbc50627f2a Co-authored-by: mnkiefer <8320933+mnkiefer@users.noreply.github.com>
Reverted |
|
@copilot Revert |
Agent-Logs-Url: https://github.com/github/gh-aw/sessions/34757ad9-f0a7-4eba-8857-e060152b6035 Co-authored-by: mnkiefer <8320933+mnkiefer@users.noreply.github.com>
Restored |
daily-grafana-otel-instrumentation-advisor.mdto changeargstoentrypointArgsfor the Grafana container.observability-otlp.mdto support multiple OTLP endpoints with respective headers.otel.mddocs to clarify required secrets for Sentry and Grafana OTLP endpoints.