fix: add chatgpt.com to CodexDefaultDomains and recompile all workflows#30207
fix: add chatgpt.com to CodexDefaultDomains and recompile all workflows#30207
Conversation
…irewall violations Agent-Logs-Url: https://github.com/github/gh-aw/sessions/9f21f41f-da98-40eb-af54-d8eda3431301 Co-authored-by: gh-aw-bot <259018956+gh-aw-bot@users.noreply.github.com>
|
@lpcox anything against this? |
There was a problem hiding this comment.
Pull request overview
Adds chatgpt.com to the Codex engine’s default allowlist so Codex CLI auth/telemetry calls stop getting blocked by the AWF firewall (notably in the AI Moderator workflow).
Changes:
- Add
chatgpt.comtoCodexDefaultDomains. - Update
TestCodexDefaultDomainsexpected domains to includechatgpt.com. - Recompile
.github/workflows/ai-moderator.lock.ymlsoGH_AW_ALLOWED_DOMAINSand AWFallowDomainsincludechatgpt.com.
Show a summary per file
| File | Description |
|---|---|
| pkg/workflow/domains.go | Expands Codex default domain allowlist to include chatgpt.com. |
| pkg/workflow/domains_test.go | Updates unit test expectations for Codex default domains. |
| .github/workflows/ai-moderator.lock.yml | Updates compiled workflow allowlists so AI Moderator permits chatgpt.com. |
Copilot's findings
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Files reviewed: 3/3 changed files
- Comments generated: 1
| // CodexDefaultDomains are the minimal default domains required for Codex CLI operation | ||
| var CodexDefaultDomains = []string{ | ||
| "172.30.0.1", // AWF gateway IP - Codex resolves host.docker.internal to this IP for Rust DNS compatibility | ||
| "api.openai.com", | ||
| "chatgpt.com", // Codex CLI connects to chatgpt.com (and subdomains e.g. ab.chatgpt.com) for auth/telemetry | ||
| "host.docker.internal", | ||
| "openai.com", | ||
| } |
🧪 Test Quality Sentinel ReportTest Quality Score: 100/100✅ Excellent test quality
Test Classification Details
Analysis NotesThis PR makes a minimal, focused change:
No new test functions were added. The change extends an existing behavioral contract test — Build tag: ✅ Language SupportTests analyzed:
Verdict
📖 Understanding Test ClassificationsDesign Tests (High Value) verify what the system does:
Implementation Tests (Low Value) verify how the system does it:
Goal: Shift toward tests that describe the system's behavioral contract — the promises it makes to its users and collaborators.
|
There was a problem hiding this comment.
✅ Test Quality Sentinel: 100/100. Test quality is excellent — 0% of new tests are implementation tests (threshold: 30%). The single test modification correctly extends the behavioral contract test for CodexDefaultDomains to include the new chatgpt.com domain.
|
@copilot merge main and recompile |
…tor-workflow-allowlist # Conflicts: # .github/workflows/ai-moderator.lock.yml Co-authored-by: lpcox <15877973+lpcox@users.noreply.github.com>
…ltDomains Agent-Logs-Url: https://github.com/github/gh-aw/sessions/59800193-0bb2-4cb9-a50c-80d57a175cda Co-authored-by: lpcox <15877973+lpcox@users.noreply.github.com>
Done in 8a5037c. Merged main, rebuilt the binary, and recompiled all 213 workflows — all Codex lock files (including Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
The Codex CLI connects to
chatgpt.comandab.chatgpt.comduring operation (auth/telemetry), but these domains were absent fromCodexDefaultDomains, causing recurring AWF firewall blocks in the AI Moderator workflow and any other Codex-based workflow.Changes
pkg/workflow/domains.go— Addchatgpt.comtoCodexDefaultDomains; AWF subdomain matching automatically coversab.chatgpt.compkg/workflow/domains_test.go— UpdateTestCodexDefaultDomainsexpected set to includechatgpt.com*.lock.ymlworkflows — Recompiled all 213 workflows; all Codex lock files (includingai-moderator,smoke-codex,changeset, and others) now includechatgpt.cominGH_AW_ALLOWED_DOMAINSand AWF configallowDomainsentries