Skip to content

[code-simplifier] Flatten nested if in sandbox strict-mode validation #29676

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pelikhan merged 1 commit into from
May 2, 2026
+7 −9
Merged

[code-simplifier] Flatten nested if in sandbox strict-mode validation #29676

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 7 additions & 9 deletions pkg/workflow/strict_mode_sandbox_validation.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,15 +44,13 @@
// configuration is unambiguous. A bare object (e.g. { version: "v0.25.29" }
// with no id) would silently default to AWF in non-strict builds but that
// implicit defaulting is not acceptable in strict mode.
if !agent.Disabled {
if !isSupportedSandboxType(getAgentType(agent)) {
return fmt.Errorf(
"strict mode: 'sandbox.agent' must specify an explicit 'id' (e.g., id: awf). " +
"A sandbox agent without an 'id' is ambiguous and not allowed in strict mode. " +
"Add 'id: awf' to your sandbox.agent configuration. " +
"See: https://github.github.com/gh-aw/reference/sandbox/",
)
}
if !agent.Disabled && !isSupportedSandboxType(getAgentType(agent)) {
return fmt.Errorf(

Check failure on line 48 in pkg/workflow/strict_mode_sandbox_validation.go

View workflow job for this annotation

GitHub Actions / lint-go 

error-format: fmt.Errorf can be replaced with errors.New (perfsprint)
"strict mode: 'sandbox.agent' must specify an explicit 'id' (e.g., id: awf). " +
"A sandbox agent without an 'id' is ambiguous and not allowed in strict mode. " +
"Add 'id: awf' to your sandbox.agent configuration. " +
"See: https://github.github.com/gh-aw/reference/sandbox/",
)
}

if agent.Command != "" {
Expand Down
Loading