Consolidate duplicate formatNumber implementations

pkg/cli/audit.go

@@ -466,7 +466,7 @@ func generateAuditReport(processedRun ProcessedRun, metrics LogMetrics) string {
 	// Metrics
 	report.WriteString("## Metrics\n\n")
 	if run.TokenUsage > 0 {
-		report.WriteString(fmt.Sprintf("- **Token Usage**: %s\n", formatNumber(run.TokenUsage)))
+		report.WriteString(fmt.Sprintf("- **Token Usage**: %s\n", console.FormatNumber(run.TokenUsage)))
 	}
 	if run.EstimatedCost > 0 {
 		report.WriteString(fmt.Sprintf("- **Estimated Cost**: $%.3f\n", run.EstimatedCost))
@@ -521,11 +521,11 @@ func generateAuditReport(processedRun ProcessedRun, metrics LogMetrics) string {
 			tool := toolStats[name]
 			inputStr := "N/A"
 			if tool.MaxInputSize > 0 {
-				inputStr = formatNumber(tool.MaxInputSize)
+				inputStr = console.FormatNumber(tool.MaxInputSize)
 			}
 			outputStr := "N/A"
 			if tool.MaxOutputSize > 0 {
-				outputStr = formatNumber(tool.MaxOutputSize)
+				outputStr = console.FormatNumber(tool.MaxOutputSize)
 			}
 			durationStr := "N/A"
 			if tool.MaxDuration > 0 {

pkg/cli/audit_report.go

@@ -492,11 +492,11 @@ func renderToolUsageTable(toolUsage []ToolUsageInfo) {
 	for _, tool := range toolUsage {
 		inputStr := "N/A"
 		if tool.MaxInputSize > 0 {
-			inputStr = formatNumber(tool.MaxInputSize)
+			inputStr = console.FormatNumber(tool.MaxInputSize)
 		}
 		outputStr := "N/A"
 		if tool.MaxOutputSize > 0 {
-			outputStr = formatNumber(tool.MaxOutputSize)
+			outputStr = console.FormatNumber(tool.MaxOutputSize)
 		}
 		durationStr := "N/A"
 		if tool.MaxDuration != "" {

pkg/cli/logs.go

@@ -1723,7 +1723,7 @@
 		// Format tokens
 		tokensStr := ""
 		if run.TokenUsage > 0 {
-			tokensStr = formatNumber(run.TokenUsage)
+			tokensStr = console.FormatNumber(run.TokenUsage)
 			totalTokens += run.TokenUsage
 		}
 
@@ -1799,7 +1799,7 @@
 		"",
 		"",
 		timeutil.FormatDuration(totalDuration),
 		formatNumber(totalTokens),
 		fmt.Sprintf("%.3f", totalCost),
 		fmt.Sprintf("%d", totalTurns),
 		fmt.Sprintf("%d", totalErrors),
@@ -1838,49 +1838,6 @@
 	return metrics
 }
 
-// formatNumber formats large numbers in a human-readable way (e.g., "1k", "1.2k", "1.12M")
-func formatNumber(n int) string {
-	if n == 0 {
-		return "0"
-	}
-
-	f := float64(n)
-
-	if f < 1000 {
-		return fmt.Sprintf("%d", n)
-	} else if f < 1000000 {
-		// Format as thousands (k)
-		k := f / 1000
-		if k >= 100 {
-			return fmt.Sprintf("%.0fk", k)
-		} else if k >= 10 {
-			return fmt.Sprintf("%.1fk", k)
-		} else {
-			return fmt.Sprintf("%.2fk", k)
-		}
-	} else if f < 1000000000 {
-		// Format as millions (M)
-		m := f / 1000000
-		if m >= 100 {
-			return fmt.Sprintf("%.0fM", m)
-		} else if m >= 10 {
-			return fmt.Sprintf("%.1fM", m)
-		} else {
-			return fmt.Sprintf("%.2fM", m)
-		}
-	} else {
-		// Format as billions (B)
-		b := f / 1000000000
-		if b >= 100 {
-			return fmt.Sprintf("%.0fB", b)
-		} else if b >= 10 {
-			return fmt.Sprintf("%.1fB", b)
-		} else {
-			return fmt.Sprintf("%.2fB", b)
-		}
-	}
-}
-
 // findAgentOutputFile searches for a file named agent_output.json within the logDir tree.
 // Returns the first path found (depth-first) and a boolean indicating success.
 func findAgentOutputFile(logDir string) (string, bool) {

pkg/cli/logs_test.go

@@ -8,6 +8,7 @@ import (
 	"strings"
 	"testing"
 
+	"github.com/githubnext/gh-aw/pkg/console"
 	"github.com/githubnext/gh-aw/pkg/workflow"
 	"github.com/githubnext/gh-aw/pkg/workflow/pretty"
 )
@@ -68,9 +69,9 @@ func TestFormatNumber(t *testing.T) {
 	}
 
 	for _, test := range tests {
-		result := formatNumber(test.input)
+		result := console.FormatNumber(test.input)
 		if result != test.expected {
-			t.Errorf("formatNumber(%d) = %s, expected %s", test.input, result, test.expected)
+			t.Errorf("console.FormatNumber(%d) = %s, expected %s", test.input, result, test.expected)
 		}
 	}
 }

pkg/console/render.go

@@ -437,22 +437,22 @@ func formatFieldValueWithTag(val reflect.Value, tag consoleTag) string {
 			if val.CanInterface() {
 				switch v := val.Interface().(type) {
 				case int:
-					return formatNumberForDisplay(v)
+					return FormatNumber(v)
 				case int64:
-					return formatNumberForDisplay(int(v))
+					return FormatNumber(int(v))
 				case int32:
-					return formatNumberForDisplay(int(v))
+					return FormatNumber(int(v))
 				case uint:
-					return formatNumberForDisplay(int(v))
+					return FormatNumber(int(v))
 				case uint64:
-					return formatNumberForDisplay(int(v))
+					return FormatNumber(int(v))
 				case uint32:
-					return formatNumberForDisplay(int(v))
+					return FormatNumber(int(v))
 				}
 			}
 			// Fallback: try to parse from baseValue if it's an integer
 			if val.Kind() >= reflect.Int && val.Kind() <= reflect.Uint64 {
-				return formatNumberForDisplay(int(val.Int()))
+				return FormatNumber(int(val.Int()))
 			}
 		case "cost":
 			// Format as currency with $ prefix
@@ -539,8 +539,8 @@ func formatFileSize(size int64) string {
 	return fmt.Sprintf("%.1f %s", float64(size)/float64(div), units[exp])
 }
 
-// formatNumberForDisplay formats large numbers in a human-readable way (e.g., "1k", "1.2M")
-func formatNumberForDisplay(n int) string {
+// FormatNumber formats large numbers in a human-readable way (e.g., "1k", "1.2k", "1.12M")
+func FormatNumber(n int) string {
 	if n == 0 {
 		return "0"
 	}
@@ -551,17 +551,33 @@ func formatNumberForDisplay(n int) string {
 		return fmt.Sprintf("%d", n)
 	} else if f < 1000000 {
 		// Format as thousands (k)
-		if f < 10000 {
-			return fmt.Sprintf("%.1fk", f/1000)
+		k := f / 1000
+		if k >= 100 {
+			return fmt.Sprintf("%.0fk", k)
+		} else if k >= 10 {
+			return fmt.Sprintf("%.1fk", k)
+		} else {
+			return fmt.Sprintf("%.2fk", k)
 		}
-		return fmt.Sprintf("%.0fk", f/1000)
 	} else if f < 1000000000 {
 		// Format as millions (M)
-		if f < 10000000 {
-			return fmt.Sprintf("%.2fM", f/1000000)
+		m := f / 1000000
+		if m >= 100 {
+			return fmt.Sprintf("%.0fM", m)
+		} else if m >= 10 {
+			return fmt.Sprintf("%.1fM", m)
+		} else {
+			return fmt.Sprintf("%.2fM", m)
+		}
+	} else {
+		// Format as billions (B)
+		b := f / 1000000000
+		if b >= 100 {
+			return fmt.Sprintf("%.0fB", b)
+		} else if b >= 10 {
+			return fmt.Sprintf("%.1fB", b)
+		} else {
+			return fmt.Sprintf("%.2fB", b)
 		}
-		return fmt.Sprintf("%.1fM", f/1000000)
 	}
-	// Format as billions (B)
-	return fmt.Sprintf("%.2fB", f/1000000000)
 }

pkg/console/render_formatting_test.go

@@ -170,13 +170,13 @@ func TestFormatFieldValueWithTag_NumberFormat(t *testing.T) {
 		expected string
 	}{
 		{"int - small", 500, "500"},
-		{"int - 1k", 1000, "1.0k"},
-		{"int - 1.5k", 1500, "1.5k"},
+		{"int - 1k", 1000, "1.00k"},   // Changed: more precision for 1-9.99k
+		{"int - 1.5k", 1500, "1.50k"}, // Changed: 2 decimals for 1-9.99k
 		{"int - 1M", 1000000, "1.00M"},
 		{"int - 5M", 5000000, "5.00M"},
-		{"int64", int64(250000), "250k"},
-		{"int32", int32(1500), "1.5k"},
-		{"uint", uint(2000), "2.0k"},
+		{"int64", int64(250000), "250k"}, // No change: 100+ rounds to 0 decimals
+		{"int32", int32(1500), "1.50k"},  // Changed: 2 decimals for 1-9.99k
+		{"uint", uint(2000), "2.00k"},    // Changed: 2 decimals for 1-9.99k
 		{"uint64", uint64(3500000), "3.50M"},
 		{"uint32", uint32(750), "750"},
 	}

pkg/console/render_test.go

@@ -386,7 +386,7 @@ func TestFormatTag_InTable(t *testing.T) {
 	}
 
 	// Should format small output size
-	if !strings.Contains(output, "1.5k") {
-		t.Errorf("Output should contain formatted number '1.5k', got:\n%s", output)
+	if !strings.Contains(output, "1.50k") {
+		t.Errorf("Output should contain formatted number '1.50k', got:\n%s", output)
 	}
 }