Add cleanup step for network proxy hook files in Claude workflows#1043
Merged
Add cleanup step for network proxy hook files in Claude workflows#1043
Conversation
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
pelikhan
reviewed
Sep 26, 2025
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Update the Claude agentic engine to add a cleanup step that removes the network proxying hook files.
- only generate step if proxy is enabled
- always run, ignore errors
Add cleanup step for network proxy hook files in Claude workflows
Sep 26, 2025
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
pelikhan
reviewed
Sep 26, 2025
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
…18be-4c5c-8dfc-568fea61b839
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
if: always()and|| true)Summary of Latest Changes
Optimized Claude engine code by removing redundant engine ID checks:
Changes Made
workflowData.EngineConfig.ID == "claude"checks in three locations within the Claude engine:GetInstallationSteps()method (line 37)GetExecutionSteps()method for network settings (line 115)GetExecutionSteps()method for cleanup step (line 226 - the specific comment location)Rationale
Since these methods are part of the
ClaudeEnginestruct, the engine ID will always be "claude", making these checks unnecessary. This optimization:Technical Details
Changed conditions from:
To:
All functionality remains identical and all tests continue to pass.
Original prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.