Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/ci-doctor.lock.yml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions .github/workflows/dev.lock.yml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions .github/workflows/tidy.lock.yml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions pkg/cli/workflows/test-all.lock.yml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions pkg/cli/workflows/test-claude-max-patch-size.lock.yml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions pkg/cli/workflows/test-claude-missing-tool.lock.yml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions pkg/cli/workflows/test-claude-patch-size-exceeded.lock.yml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions pkg/cli/workflows/test-copilot-max-patch-size.lock.yml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions pkg/cli/workflows/test-copilot-missing-tool.lock.yml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions pkg/cli/workflows/test-copilot-patch-size-exceeded.lock.yml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions pkg/cli/workflows/test-playwright-screenshots.lock.yml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions pkg/cli/workflows/test-safe-jobs.lock.yml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

14 changes: 7 additions & 7 deletions pkg/workflow/agentic_output_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -69,8 +69,8 @@ This workflow tests the agentic output collection functionality.
t.Error("Expected 'Ingest agent output' step to be in generated workflow")
}

if !strings.Contains(lockContent, "- name: Upload agentic output file") {
t.Error("Expected 'Upload agentic output file' step to be in generated workflow")
if !strings.Contains(lockContent, "- name: Upload Safe Outputs") {
t.Error("Expected 'Upload Safe Outputs' step to be in generated workflow")
}

if !strings.Contains(lockContent, "- name: Upload sanitized agent output") {
Expand Down Expand Up @@ -101,13 +101,13 @@ This workflow tests the agentic output collection functionality.
t.Error("Claude workflow should NOT reference 'agent_outputs' artifact (Claude CLI no longer produces output.txt)")
}

// Verify Print Agent output step has file existence check
// Verify Print Safe Outputs step has file existence check
if !strings.Contains(lockContent, "if [ -f ${{ env.GITHUB_AW_SAFE_OUTPUTS }} ]; then") {
t.Error("Expected Print Agent output step to check if output file exists before reading it")
t.Error("Expected Print Safe Outputs step to check if output file exists before reading it")
}

if !strings.Contains(lockContent, "No agent output file found") {
t.Error("Expected Print Agent output step to provide message when no output file found")
t.Error("Expected Print Safe Outputs step to provide message when no output file found")
}

// Verify that both artifacts are uploaded
Expand Down Expand Up @@ -177,8 +177,8 @@ This workflow tests that Codex engine gets GITHUB_AW_SAFE_OUTPUTS but not engine
t.Error("Codex workflow should have 'Ingest agent output' step (GITHUB_AW_SAFE_OUTPUTS functionality)")
}

if !strings.Contains(lockContent, "- name: Upload agentic output file") {
t.Error("Codex workflow should have 'Upload agentic output file' step (GITHUB_AW_SAFE_OUTPUTS functionality)")
if !strings.Contains(lockContent, "- name: Upload Safe Outputs") {
t.Error("Codex workflow should have 'Upload Safe Outputs' step (GITHUB_AW_SAFE_OUTPUTS functionality)")
}

if !strings.Contains(lockContent, "- name: Upload sanitized agent output") {
Expand Down
4 changes: 2 additions & 2 deletions pkg/workflow/compiler.go
Original file line number Diff line number Diff line change
Expand Up @@ -2273,7 +2273,7 @@ func (c *Compiler) generateSafeOutputsConfig(data *WorkflowData) string {

// generateOutputCollectionStep generates a step that reads the output file and sets it as a GitHub Actions output
func (c *Compiler) generateOutputCollectionStep(yaml *strings.Builder, data *WorkflowData) {
yaml.WriteString(" - name: Print Agent output\n")
yaml.WriteString(" - name: Print Safe Outputs\n")
yaml.WriteString(" env:\n")
yaml.WriteString(" GITHUB_AW_SAFE_OUTPUTS: ${{ env.GITHUB_AW_SAFE_OUTPUTS }}\n")
yaml.WriteString(" run: |\n")
Expand All @@ -2292,7 +2292,7 @@ func (c *Compiler) generateOutputCollectionStep(yaml *strings.Builder, data *Wor
yaml.WriteString(" echo '``````' >> $GITHUB_STEP_SUMMARY\n")
yaml.WriteString(" echo \"\" >> $GITHUB_STEP_SUMMARY\n")

yaml.WriteString(" - name: Upload agentic output file\n")
yaml.WriteString(" - name: Upload Safe Outputs\n")
yaml.WriteString(" if: always()\n")
yaml.WriteString(" uses: actions/upload-artifact@v4\n")
yaml.WriteString(" with:\n")
Expand Down
Loading