-
Notifications
You must be signed in to change notification settings - Fork 61.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
إضافة وثائق الاتصال الصوتي #37151
The head ref may contain hidden characters: "\u0625\u0636\u0627\u0641\u0629-\u0635\u0648\u062A-\u0627\u0644\u062A\u0648\u0627\u0635\u0644"
إضافة وثائق الاتصال الصوتي #37151
Conversation
Add voice communication documentation and update related files. * **README.md** - Add a new section for voice communication with a link to the new documentation. * **content/voice-communication.md** - Create a new file with detailed documentation on setting up and using voice communication. * **content/contributing/collaborating-on-github-docs/about-contributing-to-github-docs.md** - Add a reference to the new voice communication documentation. * **src/archives/tests/deprecated-enterprise-versions.ts** - Add a test case to verify the presence of the new voice communication documentation. --- For more details, open the [Copilot Workspace session](https://copilot-workspace.githubnext.com/github/docs?shareId=XXXX-XXXX-XXXX-XXXX).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This pull request adds documentation for voice communication and updates relevant files to reference the new documentation.
- New voice communication documentation is created.
- README.md and contributing documentation are updated to include links to the new documentation.
- A test case is added to verify the presence of the new voice communication documentation.
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
File | Description |
---|---|
src/archives/tests/deprecated-enterprise-versions.ts | Updated cache-control matcher and added test case for voice communication documentation. |
content/voice-communication.md | New file providing detailed voice communication setup and usage instructions. |
content/contributing/collaborating-on-github-docs/about-contributing-to-github-docs.md | Added reference to voice communication documentation. |
README.md | Added a new section linking to the voice communication documentation. |
@@ -336,7 +336,7 @@ describe('JS and CSS assets', () => { | |||
expect(result.headers['x-is-archived']).toBeUndefined() | |||
expect(result.headers['content-type']).toBe('text/plain; charset=utf-8') | |||
expect(result.headers['cache-control']).toContain('public') | |||
expect(result.headers['cache-control']).toMatch(/max-age=[1-9]/) | |||
expect(result.headers['cache-control']).Match(/max-age=[1-9]/) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The matcher method 'Match' is incorrect; it should be 'toMatch' to properly evaluate the regular expression.
expect(result.headers['cache-control']).Match(/max-age=[1-9]/) | |
expect(result.headers['cache-control']).toMatch(/max-age=[1-9]/) |
Copilot is powered by AI, so mistakes are possible. Review output carefully before use.
👋 Hey there spelunker. It looks like you've modified some files that we can't accept as contributions:
You'll need to revert all of the files you changed that match that list using GitHub Desktop or The complete list of files we can't accept are:
We also can't accept contributions to files in the content directory with frontmatter |
How to review these changes 👓Thank you for your contribution. To review these changes, choose one of the following options: A Hubber will need to deploy your changes internally to review. Table of review linksThe table shows the files in the
Key: fpt: Free, Pro, Team; ghec: GitHub Enterprise Cloud; ghes: GitHub Enterprise Server 🤖 This comment is automatically generated. |
Add voice communication documentation and update related files.
README.md
content/voice-communication.md
content/contributing/collaborating-on-github-docs/about-contributing-to-github-docs.md
src/archives/tests/deprecated-enterprise-versions.ts
For more details, open the Copilot Workspace session.