Rust: Add placeholder declarations for &mut and *mut
#20892
Merged
+6
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hvitved
force-pushed
the
rust/builtin-mut-placeholders
branch
from
790185b to
17e1e17
Compare
Copilot finished reviewing on behalf of
hvitved
November 24, 2025 07:36
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds placeholder struct declarations for RefMut and PtrMut to represent mutable reference (&mut) and mutable pointer (*mut) types in the Rust builtin types system. These additions prepare the codebase for future support of distinguishing between mutable and const types.
- Removed TODO comments for mut variants
- Added
RefMut<TRefMut>andPtrMut<TPtrMut>struct declarations - Updated test expectations to include the new types
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| rust/tools/builtins/types.rs | Added RefMut and PtrMut placeholder structs for mutable reference and pointer types, removing previous TODO comments |
| rust/ql/test/library-tests/elements/builtintypes/BuiltinTypes.expected | Updated generated test expectations to include the new PtrMut and RefMut types in alphabetical order |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding these declarations now mean we will already have DBs with those entities available once we implement support for distinguishing
mut/consttypes.