-
Notifications
You must be signed in to change notification settings - Fork 1.8k
Rust [EXPERIMENT]: Reduce all query suites to just type inference #20721
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
hvitved
wants to merge
1
commit into
github:main
Choose a base branch
from
hvitved:rust/type-inference-experiment
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+34
−16
Draft
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,3 +1,4 @@ | ||
| - queries: . | ||
| - apply: code-quality-extended-selectors.yml | ||
| from: codeql/suite-helpers | ||
| - include: | ||
| tags contain: | ||
| - type-inference-warmup |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,3 +1,4 @@ | ||
| - queries: . | ||
| - apply: code-quality-selectors.yml | ||
| from: codeql/suite-helpers | ||
| - include: | ||
| tags contain: | ||
| - type-inference-warmup |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,4 @@ | ||
| - description: Standard Code Scanning queries for Rust | ||
| - queries: . | ||
| - apply: code-scanning-selectors.yml | ||
| from: codeql/suite-helpers | ||
| - include: | ||
| tags contain: | ||
| - type-inference-warmup |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,4 @@ | ||
| - description: Security-and-quality queries for Rust | ||
| - queries: . | ||
| - apply: security-and-quality-selectors.yml | ||
| from: codeql/suite-helpers | ||
| - include: | ||
| tags contain: | ||
| - type-inference-warmup |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,4 @@ | ||
| - description: Extended and experimental security queries for Rust | ||
| - queries: . | ||
| - apply: security-experimental-selectors.yml | ||
| from: codeql/suite-helpers | ||
| - include: | ||
| tags contain: | ||
| - type-inference-warmup |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,4 @@ | ||
| - description: Security-extended queries for Rust | ||
| - queries: . | ||
| - apply: security-extended-selectors.yml | ||
| from: codeql/suite-helpers | ||
| - include: | ||
| tags contain: | ||
| - type-inference-warmup |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,16 @@ | ||
| /** | ||
| * @name Warmup type inference cache | ||
| * @description Exercises the type inference implementation to make sure that it is in the cache. | ||
| * @kind problem | ||
| * @problem.severity recommendation | ||
| * @id rust/diagnostics/type-inference-warmup | ||
| * @tags type-inference-warmup | ||
| */ | ||
|
|
||
| import rust | ||
| import codeql.rust.internal.Type | ||
| import codeql.rust.internal.TypeInference | ||
|
|
||
| from UnitType t | ||
| where t = inferType(_) | ||
| select t, "Dummy result" | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check warning
Code scanning / CodeQL
Alert message style violation Warning