JS: mark GraphQLObjectType resolvers args as remote sources
#20492
+47
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for treating GraphQL resolver function parameters in GraphQLObjectType as remote sources for security analysis. This enhancement improves code injection detection by recognizing user-controlled data flowing through GraphQL resolvers.
- Adds a new model entry for
GraphQLObjectTyperesolver parameters as remote sources - Includes a test case demonstrating code injection through GraphQL resolvers
- Updates expected test results to reflect the new security detection capabilities
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| javascript/ql/lib/ext/graph-ql.model.yml | Adds source model for GraphQLObjectType resolver parameters |
| javascript/ql/test/query-tests/Security/CWE-094/CodeInjection/graph-ql.js | Adds test case with GraphQLObjectType resolver vulnerable to code injection |
| javascript/ql/test/query-tests/Security/CWE-094/CodeInjection/CodeInjection.expected | Updates expected results to include new code injection detection |
| javascript/ql/test/query-tests/Security/CWE-094/CodeInjection/HeuristicSourceCodeInjection.expected | Updates expected results for heuristic code injection detection |
| javascript/ql/lib/change-notes/2025-09-19-graphql-type-object.md | Documents the enhancement for GraphQLObjectType modeling |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.