Java: Add query to detect non-case labels in switch statements #19998
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces a new CodeQL query for detecting non-case labels in Java
switch
statements, which can be confusing or indicative of bugs.This query was migrated from the internal repo. I somewhat changed the query to report two alert messages depending on whether the found label is used or not.
I've manually checked autofix suggestions on a couple of repos. Autofix can suggest both the trivial missing
case
keyword, and also can refactor the code, and move it into a separate method, and then call that method. (I guess the latter has some limitations, but my samples were relatively simple)