Rust: Update PoemHandlerParam to use getCanonicalPath

[geoffw0]

Update PoemHandlerParam to use getCanonicalPath rather than getResolvedPath.

@hvitved

[Copilot]

Pull Request Overview

Updates the PoemHandlerParam predicate to use getCanonicalPath on an inferred type rather than the deprecated getResolvedPath.

• Added imports for TypeInference and Type
• Switched from matching getResolvedPath to inferring the type and checking its canonical path
• Refactored the exists clause to bind the inferred type and perform the new path comparison

Comments suppressed due to low confidence (3)

rust/ql/lib/codeql/rust/frameworks/Poem.qll:16

• [nitpick] The variable name t is ambiguous; consider renaming it to paramType or inferredType for clarity.

    exists(TupleStructPat param, Type t |

rust/ql/lib/codeql/rust/frameworks/Poem.qll:12

• The doc comment still refers to handler parameters in terms of path resolution; update it to mention canonical path checking via type inference.

 * Parameters of a handler function

rust/ql/lib/codeql/rust/frameworks/Poem.qll:16

• Add unit tests for PoemHandlerParam to cover both Query and Path cases with the new canonical path logic.

    exists(TupleStructPat param, Type t |

[hvitved]

I think it would be better to add this predicate to TupleStructPatImpl.qll:

    /** Gets the struct matched by this pattern. */
    Struct getStruct() { result = PathResolution::resolvePath(this.getPath()) }

and then change the above to param.getStruct().getCanonicalPath() = ....

[geoffw0]

Updated.

[hvitved]

Should now be removed (as well as the two imports).

[geoffw0]

Sorry, the heat must be getting to me. Now done.