-
Notifications
You must be signed in to change notification settings - Fork 1.7k
JS: Mass promotion of queries to quality status
#19776
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Napalys
wants to merge
15
commits into
github:main
Choose a base branch
from
Napalys:js/mass_quality_promotion
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+429
−111
Open
Changes from all commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
0c31838
JS: mass add missing quality related tags to relevant queries
Napalys b14b661
JS: add change note
Napalys 119c1e6
Merge remote-tracking branch 'origin/main' into js/mass_quality_promo…
Napalys 8b2bb07
Updated quality extended expected file after merge
Napalys 244bf42
JS: Fixed typo.
Napalys c18fe30
JS: Changed `MissingThisQualifier` to `reliability` and `correctness`
Napalys ad6c6b2
Changed `js/angular/dependency-injection-mismatch` to `reliability` a…
Napalys bb9a228
Changed `js/conditional-comment` to `reliability` and `correctness`
Napalys c1d29cc
Changed `js/whitespace-contradicts-precedence` to `reliability` and `…
Napalys 2ab35d6
Changed `js/node/assignment-to-exports-variable` to `reliability` and…
Napalys 125add1
Changed `js/node/missing-exports-qualifier` to `reliability` and `cor…
Napalys 4bc9732
Changed `js/label-in-switch` to `reliability` and `correctness`
Napalys 4fd3ef8
Changed `js/useless-assignment-in-return` to `reliability` and `corre…
Napalys 32dd665
Changed `js/unused-loop-variable` to `reliability` and `correctness`
Napalys aa3e9c6
Changed `js/unreachable-statement` to `reliability` and `correctness`
Napalys File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
89 changes: 89 additions & 0 deletions
89
javascript/ql/integration-tests/query-suite/javascript-code-quality-extended.qls.expected
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,9 +1,98 @@ | ||
| ql/javascript/ql/src/AngularJS/DependencyMismatch.ql | ||
| ql/javascript/ql/src/AngularJS/DuplicateDependency.ql | ||
| ql/javascript/ql/src/AngularJS/IncompatibleService.ql | ||
| ql/javascript/ql/src/AngularJS/MissingExplicitInjection.ql | ||
| ql/javascript/ql/src/AngularJS/RepeatedInjection.ql | ||
| ql/javascript/ql/src/AngularJS/UseNgSrc.ql | ||
| ql/javascript/ql/src/DOM/DuplicateAttributes.ql | ||
| ql/javascript/ql/src/DOM/MalformedIdAttribute.ql | ||
| ql/javascript/ql/src/DOM/PseudoEval.ql | ||
| ql/javascript/ql/src/Declarations/ArgumentsRedefined.ql | ||
| ql/javascript/ql/src/Declarations/AssignmentToConst.ql | ||
| ql/javascript/ql/src/Declarations/ClobberingVarInit.ql | ||
| ql/javascript/ql/src/Declarations/ConflictingFunctions.ql | ||
| ql/javascript/ql/src/Declarations/DeadStoreOfLocal.ql | ||
| ql/javascript/ql/src/Declarations/DeadStoreOfProperty.ql | ||
| ql/javascript/ql/src/Declarations/DeclBeforeUse.ql | ||
| ql/javascript/ql/src/Declarations/DefaultArgumentReferencesNestedFunction.ql | ||
| ql/javascript/ql/src/Declarations/DuplicateVarDecl.ql | ||
| ql/javascript/ql/src/Declarations/IneffectiveParameterType.ql | ||
| ql/javascript/ql/src/Declarations/MissingThisQualifier.ql | ||
| ql/javascript/ql/src/Declarations/MissingVarDecl.ql | ||
| ql/javascript/ql/src/Declarations/MixedStaticInstanceThisAccess.ql | ||
| ql/javascript/ql/src/Declarations/SuspiciousMethodNameDeclaration.ql | ||
| ql/javascript/ql/src/Declarations/TemporalDeadZone.ql | ||
| ql/javascript/ql/src/Declarations/UniqueParameterNames.ql | ||
| ql/javascript/ql/src/Declarations/UniquePropertyNames.ql | ||
| ql/javascript/ql/src/Declarations/UnreachableMethodOverloads.ql | ||
| ql/javascript/ql/src/Declarations/UnusedVariable.ql | ||
| ql/javascript/ql/src/Expressions/ComparisonWithNaN.ql | ||
| ql/javascript/ql/src/Expressions/DuplicateCondition.ql | ||
| ql/javascript/ql/src/Expressions/DuplicateProperty.ql | ||
| ql/javascript/ql/src/Expressions/DuplicateSwitchCase.ql | ||
| ql/javascript/ql/src/Expressions/ExprHasNoEffect.ql | ||
| ql/javascript/ql/src/Expressions/HeterogeneousComparison.ql | ||
| ql/javascript/ql/src/Expressions/ImplicitOperandConversion.ql | ||
| ql/javascript/ql/src/Expressions/MissingAwait.ql | ||
| ql/javascript/ql/src/Expressions/MissingDotLengthInComparison.ql | ||
| ql/javascript/ql/src/Expressions/MissingSpaceInAppend.ql | ||
| ql/javascript/ql/src/Expressions/MisspelledVariableName.ql | ||
| ql/javascript/ql/src/Expressions/RedundantExpression.ql | ||
| ql/javascript/ql/src/Expressions/SelfAssignment.ql | ||
| ql/javascript/ql/src/Expressions/ShiftOutOfRange.ql | ||
| ql/javascript/ql/src/Expressions/StringInsteadOfRegex.ql | ||
| ql/javascript/ql/src/Expressions/SuspiciousInvocation.ql | ||
| ql/javascript/ql/src/Expressions/SuspiciousPropAccess.ql | ||
| ql/javascript/ql/src/Expressions/UnboundEventHandlerReceiver.ql | ||
| ql/javascript/ql/src/Expressions/UnclearOperatorPrecedence.ql | ||
| ql/javascript/ql/src/Expressions/UnknownDirective.ql | ||
| ql/javascript/ql/src/Expressions/UnneededDefensiveProgramming.ql | ||
| ql/javascript/ql/src/Expressions/WhitespaceContradictsPrecedence.ql | ||
| ql/javascript/ql/src/LanguageFeatures/BadTypeof.ql | ||
| ql/javascript/ql/src/LanguageFeatures/ConditionalComments.ql | ||
| ql/javascript/ql/src/LanguageFeatures/DeleteVar.ql | ||
| ql/javascript/ql/src/LanguageFeatures/ExpressionClosures.ql | ||
| ql/javascript/ql/src/LanguageFeatures/ForInComprehensionBlocks.ql | ||
| ql/javascript/ql/src/LanguageFeatures/IllegalInvocation.ql | ||
| ql/javascript/ql/src/LanguageFeatures/InconsistentNew.ql | ||
| ql/javascript/ql/src/LanguageFeatures/InvalidPrototype.ql | ||
| ql/javascript/ql/src/LanguageFeatures/LengthComparisonOffByOne.ql | ||
| ql/javascript/ql/src/LanguageFeatures/NonLinearPattern.ql | ||
| ql/javascript/ql/src/LanguageFeatures/PropertyWriteOnPrimitive.ql | ||
| ql/javascript/ql/src/LanguageFeatures/SemicolonInsertion.ql | ||
| ql/javascript/ql/src/LanguageFeatures/SetterReturn.ql | ||
| ql/javascript/ql/src/LanguageFeatures/SpuriousArguments.ql | ||
| ql/javascript/ql/src/LanguageFeatures/StrictModeCallStackIntrospection.ql | ||
| ql/javascript/ql/src/LanguageFeatures/SyntaxError.ql | ||
| ql/javascript/ql/src/LanguageFeatures/TemplateSyntaxInStringLiteral.ql | ||
| ql/javascript/ql/src/LanguageFeatures/ThisBeforeSuper.ql | ||
| ql/javascript/ql/src/LanguageFeatures/UnusedIndexVariable.ql | ||
| ql/javascript/ql/src/LanguageFeatures/WithStatement.ql | ||
| ql/javascript/ql/src/LanguageFeatures/YieldInNonGenerator.ql | ||
| ql/javascript/ql/src/NodeJS/InvalidExport.ql | ||
| ql/javascript/ql/src/NodeJS/MissingExports.ql | ||
| ql/javascript/ql/src/Quality/UnhandledErrorInStreamPipeline.ql | ||
| ql/javascript/ql/src/React/DirectStateMutation.ql | ||
| ql/javascript/ql/src/React/InconsistentStateUpdate.ql | ||
| ql/javascript/ql/src/React/UnsupportedStateUpdateInLifecycleMethod.ql | ||
| ql/javascript/ql/src/React/UnusedOrUndefinedStateProperty.ql | ||
| ql/javascript/ql/src/RegExp/BackrefBeforeGroup.ql | ||
| ql/javascript/ql/src/RegExp/BackrefIntoNegativeLookahead.ql | ||
| ql/javascript/ql/src/RegExp/DuplicateCharacterInCharacterClass.ql | ||
| ql/javascript/ql/src/RegExp/EmptyCharacterClass.ql | ||
| ql/javascript/ql/src/RegExp/RegExpAlwaysMatches.ql | ||
| ql/javascript/ql/src/RegExp/UnboundBackref.ql | ||
| ql/javascript/ql/src/RegExp/UnmatchableCaret.ql | ||
| ql/javascript/ql/src/RegExp/UnmatchableDollar.ql | ||
| ql/javascript/ql/src/Statements/DanglingElse.ql | ||
| ql/javascript/ql/src/Statements/IgnoreArrayResult.ql | ||
| ql/javascript/ql/src/Statements/InconsistentLoopOrientation.ql | ||
| ql/javascript/ql/src/Statements/LabelInCase.ql | ||
| ql/javascript/ql/src/Statements/MisleadingIndentationAfterControlStmt.ql | ||
| ql/javascript/ql/src/Statements/ReturnAssignsLocal.ql | ||
| ql/javascript/ql/src/Statements/SuspiciousUnusedLoopIterationVariable.ql | ||
| ql/javascript/ql/src/Statements/UnreachableStatement.ql | ||
| ql/javascript/ql/src/Statements/UseOfReturnlessFunction.ql | ||
| ql/javascript/ql/src/Statements/UselessComparisonTest.ql | ||
| ql/javascript/ql/src/Statements/UselessConditional.ql | ||
| ql/javascript/ql/src/Vue/ArrowMethodOnVueInstance.ql |
89 changes: 89 additions & 0 deletions
89
javascript/ql/integration-tests/query-suite/javascript-code-quality.qls.expected
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,9 +1,98 @@ | ||
| ql/javascript/ql/src/AngularJS/DependencyMismatch.ql | ||
| ql/javascript/ql/src/AngularJS/DuplicateDependency.ql | ||
| ql/javascript/ql/src/AngularJS/IncompatibleService.ql | ||
| ql/javascript/ql/src/AngularJS/MissingExplicitInjection.ql | ||
| ql/javascript/ql/src/AngularJS/RepeatedInjection.ql | ||
| ql/javascript/ql/src/AngularJS/UseNgSrc.ql | ||
| ql/javascript/ql/src/DOM/DuplicateAttributes.ql | ||
| ql/javascript/ql/src/DOM/MalformedIdAttribute.ql | ||
| ql/javascript/ql/src/DOM/PseudoEval.ql | ||
| ql/javascript/ql/src/Declarations/ArgumentsRedefined.ql | ||
| ql/javascript/ql/src/Declarations/AssignmentToConst.ql | ||
| ql/javascript/ql/src/Declarations/ClobberingVarInit.ql | ||
| ql/javascript/ql/src/Declarations/ConflictingFunctions.ql | ||
| ql/javascript/ql/src/Declarations/DeadStoreOfLocal.ql | ||
| ql/javascript/ql/src/Declarations/DeadStoreOfProperty.ql | ||
| ql/javascript/ql/src/Declarations/DeclBeforeUse.ql | ||
| ql/javascript/ql/src/Declarations/DefaultArgumentReferencesNestedFunction.ql | ||
| ql/javascript/ql/src/Declarations/DuplicateVarDecl.ql | ||
| ql/javascript/ql/src/Declarations/IneffectiveParameterType.ql | ||
| ql/javascript/ql/src/Declarations/MissingThisQualifier.ql | ||
| ql/javascript/ql/src/Declarations/MissingVarDecl.ql | ||
| ql/javascript/ql/src/Declarations/MixedStaticInstanceThisAccess.ql | ||
| ql/javascript/ql/src/Declarations/SuspiciousMethodNameDeclaration.ql | ||
| ql/javascript/ql/src/Declarations/TemporalDeadZone.ql | ||
| ql/javascript/ql/src/Declarations/UniqueParameterNames.ql | ||
| ql/javascript/ql/src/Declarations/UniquePropertyNames.ql | ||
| ql/javascript/ql/src/Declarations/UnreachableMethodOverloads.ql | ||
| ql/javascript/ql/src/Declarations/UnusedVariable.ql | ||
| ql/javascript/ql/src/Expressions/ComparisonWithNaN.ql | ||
| ql/javascript/ql/src/Expressions/DuplicateCondition.ql | ||
| ql/javascript/ql/src/Expressions/DuplicateProperty.ql | ||
| ql/javascript/ql/src/Expressions/DuplicateSwitchCase.ql | ||
| ql/javascript/ql/src/Expressions/ExprHasNoEffect.ql | ||
| ql/javascript/ql/src/Expressions/HeterogeneousComparison.ql | ||
| ql/javascript/ql/src/Expressions/ImplicitOperandConversion.ql | ||
| ql/javascript/ql/src/Expressions/MissingAwait.ql | ||
| ql/javascript/ql/src/Expressions/MissingDotLengthInComparison.ql | ||
| ql/javascript/ql/src/Expressions/MissingSpaceInAppend.ql | ||
| ql/javascript/ql/src/Expressions/MisspelledVariableName.ql | ||
| ql/javascript/ql/src/Expressions/RedundantExpression.ql | ||
| ql/javascript/ql/src/Expressions/SelfAssignment.ql | ||
| ql/javascript/ql/src/Expressions/ShiftOutOfRange.ql | ||
| ql/javascript/ql/src/Expressions/StringInsteadOfRegex.ql | ||
| ql/javascript/ql/src/Expressions/SuspiciousInvocation.ql | ||
| ql/javascript/ql/src/Expressions/SuspiciousPropAccess.ql | ||
| ql/javascript/ql/src/Expressions/UnboundEventHandlerReceiver.ql | ||
| ql/javascript/ql/src/Expressions/UnclearOperatorPrecedence.ql | ||
| ql/javascript/ql/src/Expressions/UnknownDirective.ql | ||
| ql/javascript/ql/src/Expressions/UnneededDefensiveProgramming.ql | ||
| ql/javascript/ql/src/Expressions/WhitespaceContradictsPrecedence.ql | ||
| ql/javascript/ql/src/LanguageFeatures/BadTypeof.ql | ||
| ql/javascript/ql/src/LanguageFeatures/ConditionalComments.ql | ||
| ql/javascript/ql/src/LanguageFeatures/DeleteVar.ql | ||
| ql/javascript/ql/src/LanguageFeatures/ExpressionClosures.ql | ||
| ql/javascript/ql/src/LanguageFeatures/ForInComprehensionBlocks.ql | ||
| ql/javascript/ql/src/LanguageFeatures/IllegalInvocation.ql | ||
| ql/javascript/ql/src/LanguageFeatures/InconsistentNew.ql | ||
| ql/javascript/ql/src/LanguageFeatures/InvalidPrototype.ql | ||
| ql/javascript/ql/src/LanguageFeatures/LengthComparisonOffByOne.ql | ||
| ql/javascript/ql/src/LanguageFeatures/NonLinearPattern.ql | ||
| ql/javascript/ql/src/LanguageFeatures/PropertyWriteOnPrimitive.ql | ||
| ql/javascript/ql/src/LanguageFeatures/SemicolonInsertion.ql | ||
| ql/javascript/ql/src/LanguageFeatures/SetterReturn.ql | ||
| ql/javascript/ql/src/LanguageFeatures/SpuriousArguments.ql | ||
| ql/javascript/ql/src/LanguageFeatures/StrictModeCallStackIntrospection.ql | ||
| ql/javascript/ql/src/LanguageFeatures/SyntaxError.ql | ||
| ql/javascript/ql/src/LanguageFeatures/TemplateSyntaxInStringLiteral.ql | ||
| ql/javascript/ql/src/LanguageFeatures/ThisBeforeSuper.ql | ||
| ql/javascript/ql/src/LanguageFeatures/UnusedIndexVariable.ql | ||
| ql/javascript/ql/src/LanguageFeatures/WithStatement.ql | ||
| ql/javascript/ql/src/LanguageFeatures/YieldInNonGenerator.ql | ||
| ql/javascript/ql/src/NodeJS/InvalidExport.ql | ||
| ql/javascript/ql/src/NodeJS/MissingExports.ql | ||
| ql/javascript/ql/src/Quality/UnhandledErrorInStreamPipeline.ql | ||
| ql/javascript/ql/src/React/DirectStateMutation.ql | ||
| ql/javascript/ql/src/React/InconsistentStateUpdate.ql | ||
| ql/javascript/ql/src/React/UnsupportedStateUpdateInLifecycleMethod.ql | ||
| ql/javascript/ql/src/React/UnusedOrUndefinedStateProperty.ql | ||
| ql/javascript/ql/src/RegExp/BackrefBeforeGroup.ql | ||
| ql/javascript/ql/src/RegExp/BackrefIntoNegativeLookahead.ql | ||
| ql/javascript/ql/src/RegExp/DuplicateCharacterInCharacterClass.ql | ||
| ql/javascript/ql/src/RegExp/EmptyCharacterClass.ql | ||
| ql/javascript/ql/src/RegExp/RegExpAlwaysMatches.ql | ||
| ql/javascript/ql/src/RegExp/UnboundBackref.ql | ||
| ql/javascript/ql/src/RegExp/UnmatchableCaret.ql | ||
| ql/javascript/ql/src/RegExp/UnmatchableDollar.ql | ||
| ql/javascript/ql/src/Statements/DanglingElse.ql | ||
| ql/javascript/ql/src/Statements/IgnoreArrayResult.ql | ||
| ql/javascript/ql/src/Statements/InconsistentLoopOrientation.ql | ||
| ql/javascript/ql/src/Statements/LabelInCase.ql | ||
| ql/javascript/ql/src/Statements/MisleadingIndentationAfterControlStmt.ql | ||
| ql/javascript/ql/src/Statements/ReturnAssignsLocal.ql | ||
| ql/javascript/ql/src/Statements/SuspiciousUnusedLoopIterationVariable.ql | ||
| ql/javascript/ql/src/Statements/UnreachableStatement.ql | ||
| ql/javascript/ql/src/Statements/UseOfReturnlessFunction.ql | ||
| ql/javascript/ql/src/Statements/UselessComparisonTest.ql | ||
| ql/javascript/ql/src/Statements/UselessConditional.ql | ||
| ql/javascript/ql/src/Vue/ArrowMethodOnVueInstance.ql |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.