Rust: skip private items when extracting library files #19581
+58
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aibaars
force-pushed
the
aibaars/rust-extract-libs
branch
from
edd401e to
e07b036
Compare
aibaars
force-pushed
the
aibaars/rust-extract-libs
branch
from
e07b036 to
5d23d47
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request drops items that are "obviously" private. Those are items that lack any visibility modifier. It also excludes items in
traitsand inimplblock that implement a trait. Items that are generated by macros are not excluded as these are typically wrapped in a detached MacroItems node making it harder to determine whether they are part of a trait or not.