Skip to content

Rust: Allow implicit reads from reference content in taint reach. #19306

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

geoffw0
Copy link
Contributor

@geoffw0 geoffw0 commented Apr 14, 2025

Allow implicit reads from reference content in the taint reach calculation:

  • the metric was designed without content in mind. As written nodes reached with content on them do not count as reached in the metric, which leads to undercounting.
  • however allowing any content produces a huge cartesian product in allowImplicitRead.
  • as a compromise, allow implicit read for reference content, which I hypothesize may be responsible for a big part of the undercounting (DCA to confirm).

@geoffw0 geoffw0 added no-change-note-required This PR does not need a change note Rust Pull requests that update Rust code labels Apr 14, 2025
@geoffw0
Copy link
Contributor Author

geoffw0 commented Apr 17, 2025

DCA shows no increase in taint reach. I'd better take a closer look at what's going on...

@geoffw0
Copy link
Contributor Author

geoffw0 commented Apr 17, 2025

Allowing implicit reads of TuplePositionContent has a bigger impact, but it's not very principled to pick just that one out. As mentioned above, allowing implicit reads of any content breaks performance (cartesian product). Think I'll just close this and make do with the metric as it is.

@geoffw0 geoffw0 closed this Apr 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-change-note-required This PR does not need a change note Rust Pull requests that update Rust code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant