Skip to content

Conversation

GeekMasher
Copy link
Contributor

No description provided.

GeekMasher and others added 4 commits March 3, 2025 12:09
- Settle on `DataFlowCallable` as `Callable`.
Alternative is to use (something extending) `Function,`
but then we ned to implement enclosing callable.
- Reuse `EndPoint` from ModelEditor.qll.
- clean up comments
@Copilot Copilot AI review requested due to automatic review settings March 27, 2025 13:28
@GeekMasher GeekMasher requested a review from a team as a code owner March 27, 2025 13:28
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review any files in this pull request.

Files not reviewed (8)
  • python/ql/lib/modeling/Util.qll: Language not supported
  • python/ql/lib/semmle/python/dataflow/new/internal/DataFlowDispatch.qll: Language not supported
  • python/ql/lib/semmle/python/frameworks/data/internal/ApiGraphModels.qll: Language not supported
  • python/ql/src/utils/modelgenerator/CaptureNeutralModels.ql: Language not supported
  • python/ql/src/utils/modelgenerator/CaptureSinkModels.ql: Language not supported
  • python/ql/src/utils/modelgenerator/CaptureSourceModels.ql: Language not supported
  • python/ql/src/utils/modelgenerator/CaptureSummaryModels.ql: Language not supported
  • python/ql/src/utils/modelgenerator/internal/CaptureModels.qll: Language not supported

Tip: If you use Visual Studio Code, you can request a review from Copilot before you push from the "Source Control" tab. Learn more


predicate isRelevantType(Type t) { any() }

Type getUnderlyingContentType(DataFlow::ContentSet c) { result = any(Type t) and exists(c) }

Check warning

Code scanning / CodeQL

Redundant cast Warning

Redundant cast to
Unit
.
Copy link
Contributor

@yoff yoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One question about the parameter position. Otherwise this looks fine for now. Happy to approve this once CI is passing.

Comment on lines +88 to +92
/** Gets the underlying integer position, if any. */
int getPosition() {
this = TPositionalParameterPosition(result)
}

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this still needed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants