-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Python: Initial version of the Model Generator Lib and Queries #19131
base: main
Are you sure you want to change the base?
Conversation
- Settle on `DataFlowCallable` as `Callable`. Alternative is to use (something extending) `Function,` but then we ned to implement enclosing callable. - Reuse `EndPoint` from ModelEditor.qll. - clean up comments
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot wasn't able to review any files in this pull request.
Files not reviewed (8)
- python/ql/lib/modeling/Util.qll: Language not supported
- python/ql/lib/semmle/python/dataflow/new/internal/DataFlowDispatch.qll: Language not supported
- python/ql/lib/semmle/python/frameworks/data/internal/ApiGraphModels.qll: Language not supported
- python/ql/src/utils/modelgenerator/CaptureNeutralModels.ql: Language not supported
- python/ql/src/utils/modelgenerator/CaptureSinkModels.ql: Language not supported
- python/ql/src/utils/modelgenerator/CaptureSourceModels.ql: Language not supported
- python/ql/src/utils/modelgenerator/CaptureSummaryModels.ql: Language not supported
- python/ql/src/utils/modelgenerator/internal/CaptureModels.qll: Language not supported
Tip: If you use Visual Studio Code, you can request a review from Copilot before you push from the "Source Control" tab. Learn more
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One question about the parameter position. Otherwise this looks fine for now. Happy to approve this once CI is passing.
/** Gets the underlying integer position, if any. */ | ||
int getPosition() { | ||
this = TPositionalParameterPosition(result) | ||
} | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this still needed?
No description provided.