Skip to content

C#: Make getPreUpdateNode Unique Again #19128

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 28, 2025

Conversation

hvitved
Copy link
Contributor

@hvitved hvitved commented Mar 26, 2025

Same as #19121, but for C#. Reverts the non-uniqueness introduced in #10594.

@github-actions github-actions bot added the C# label Mar 26, 2025
@hvitved hvitved force-pushed the csharp/pre-update-unique branch from 38ebb45 to 023ffe2 Compare March 26, 2025 13:42
@hvitved hvitved added the no-change-note-required This PR does not need a change note label Mar 27, 2025
@hvitved hvitved marked this pull request as ready for review March 27, 2025 10:20
@Copilot Copilot AI review requested due to automatic review settings March 27, 2025 10:20
@hvitved hvitved requested a review from a team as a code owner March 27, 2025 10:20
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review any files in this pull request.

Files not reviewed (4)
  • csharp/ql/consistency-queries/DataFlowConsistency.ql: Language not supported
  • csharp/ql/lib/semmle/code/csharp/dataflow/internal/DataFlowPrivate.qll: Language not supported
  • csharp/ql/test/library-tests/dataflow/global/DataFlowPath.expected: Language not supported
  • csharp/ql/test/library-tests/dataflow/global/TaintTrackingPath.expected: Language not supported

Tip: Copilot code review supports C#, Go, Java, JavaScript, Markdown, Python, Ruby and TypeScript, with more languages coming soon. Learn more

@hvitved hvitved merged commit 1a75c05 into github:main Mar 28, 2025
25 checks passed
@hvitved hvitved deleted the csharp/pre-update-unique branch March 28, 2025 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C# no-change-note-required This PR does not need a change note
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants