Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rust: Also resolve crate paths in non-source files #19123

Merged
merged 1 commit into from
Mar 28, 2025

Conversation

hvitved
Copy link
Contributor

@hvitved hvitved commented Mar 26, 2025

Previously, we didn't extract crate::... paths for non-source code, but starting with #19113 we do.

@github-actions github-actions bot added the Rust Pull requests that update Rust code label Mar 26, 2025
@hvitved hvitved marked this pull request as ready for review March 26, 2025 13:13
@Copilot Copilot bot review requested due to automatic review settings March 26, 2025 13:13
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review any files in this pull request.

Files not reviewed (1)
  • rust/ql/lib/codeql/rust/internal/PathResolution.qll: Language not supported

Tip: If you use Visual Studio Code, you can request a review from Copilot before you push from the "Source Control" tab. Learn more

@hvitved hvitved requested review from paldepind and Copilot March 26, 2025 13:13
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review any files in this pull request.

Files not reviewed (1)
  • rust/ql/lib/codeql/rust/internal/PathResolution.qll: Language not supported

Tip: Copilot only keeps its highest confidence comments to reduce noise and keep you focused. Learn more

Copy link
Contributor

@geoffw0 geoffw0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@hvitved hvitved merged commit f2f5739 into github:main Mar 28, 2025
16 checks passed
@hvitved hvitved deleted the rust/path-resolution-crate-non-source branch March 28, 2025 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Rust Pull requests that update Rust code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants